Skip to content

Commit

Permalink
[Settings UI] Clamp vintage cursor height and history size (#9370)
Browse files Browse the repository at this point in the history
## Summary of the Pull Request
Add `Minimum` and `Maximum` for the cursor height numberbox in the SUI.
Add `Minimum` for the history size numberbox in the SUI.

## PR Checklist
* [x] Closes #9357, Closes #9175
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Validation Steps Performed
Manual validation
  • Loading branch information
eugenesmlv committed Mar 4, 2021
1 parent 5aaf5b4 commit ac3fecb
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/cascadia/TerminalSettingsEditor/Profiles.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,8 @@ the MIT License. See LICENSE in the project root for license information. -->
Visibility="{x:Bind IsVintageCursor, Mode=OneWay}">
<muxc:NumberBox Value="{x:Bind State.Profile.CursorHeight, Mode=TwoWay}"
Style="{StaticResource NumberBoxSettingStyle}"
Minimum="1"
Maximum="100"
SmallChange="1"
LargeChange="10"/>
</local:SettingContainer>
Expand Down Expand Up @@ -662,6 +664,7 @@ the MIT License. See LICENSE in the project root for license information. -->
SettingOverrideSource="{x:Bind State.Profile.HistorySizeOverrideSource, Mode=OneWay}">
<muxc:NumberBox Value="{x:Bind State.Profile.HistorySize, Mode=TwoWay}"
Style="{StaticResource NumberBoxSettingStyle}"
Minimum="0"
SmallChange="10"
LargeChange="100"/>
</local:SettingContainer>
Expand Down

0 comments on commit ac3fecb

Please sign in to comment.