-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Setting to hide/remove close ("x") button from tabs #3335
Comments
Honestly I think that would just be a plain simple cool UI, even if all of the other issues referenced were fixed. I'm gonna tag this as a subset of #3327, and cc @cinnamon-msft, though this would probably be achievable without #3327. |
I would love to see this feature implemented as well. Hopefully some progress can be made on this as part of #3327. |
I accidentally clicked X on a tab when trying to switch to it, and it killed off an Please, we need this, and we also need confirmation prompts for closing. It's not the same as accidentally closing a browser tab, for which you could click "Reopen closed tab" and just reload the page. The data loss implications are much greater here - you're killing off running foreground processes. |
Myself, I'd also like an option to only show "×" on hover (mainly to better use horizontal space when I have a lot of tabs)… which in parts is aligned with this issue (more customizability of UI) in part is exactly opposed (I guess it would make easier to close by mistake). |
This comment was marked as spam.
This comment was marked as spam.
Is this going to be implemented? |
Probably at some point, sure. We've got the foundation for theming in PR over in #12992. Once that lands, I don't suspect it would be that hard to add a
setting to a theme. |
IDK maybe in the weekend. Haven't touched C++ in 10 years. 😄 Theory looks great though! Much love and thanks for your effort. |
Could someone please mention the link here if there ever an issue is filed for TabView/WinUI, so we can follow the progress? I find it a usability regression to not be able to middle click only because there is no close button. |
I use scaled windows with a big mouse cursor and many tabs, the inability to remove the close button means I usually avoid it entirely for fear of misclick. I'm confident in my middle-click and keyboard use, less so in single left click territory. It would be great if this could be resolved, sometimes I'm not careful and close very long-running processes by mistake. Even once is painful. |
@dezren39 Then you might be interested in |
Hi. Any working solution for this issue? |
@zohozer Please read the thread. This has been fixed in |
🎉This issue was addressed in #13348, which has now been successfully released as Handy links: |
how would this be enabled in the settings? I can't figure out from the release notes nor the commit. thanks |
As an example from my test themes: "theme": "ninety eight",
"themes":
[
{
"name": "ninety eight",
"tab":
{
"background": "#e0e3e4",
"unfocusedBackground": "#c0c0c0",
"showCloseButton": "never"
},
"tabRow":
{
"background": "#0000aa",
"unfocusedBackground": "#87888f"
},
"window":
{
"applicationTheme": "light",
"useMica": true
}
}
] |
this is the themes contents in the default config file (well I changed from dark to light using the gui settings) :
what is the minimal modification needed to enable showCloseButton on all default themes? |
would this be sufficient?
|
You'll need to change the name to something else, but yea, that'd do it. Then just change the |
FWIW, I think I initially ran into the same problem as @mailinglists35. I copied the example theme from the docs as-is and then added the It wasn't until I got things working that I went back to the docs and saw this:
My attempt to use The user might misunderstand that to mean that I'm guessing that this will be fixed by a future schema update (regarding the warning message), but wanted to note it in case it helps someone else in the meantime. |
oh, so what is the way to go if I just want the light/dark theme plus this setting? |
@atc0005 I just had to update my Windows Terminal Preview for this error to disappear.
This does hide the close button, but the middle mouse click stops closing the tab :\ even with
what do |
Read the thread: #3335 (comment).
Alas, that's just a limitation of TabView for the time being.
That's... not a setting? Where'd you conjure that from?
|
did I copy it wrong? I still see the close button.
|
before it was simply
|
Ah, you missed a crucial pair of steps:
Themes don't let you directly override built-in theme names ( |
a w e s o m e I am finally worry-free clicking anywhere in the tab bar! thank you |
Even better! 🎉 |
It would be great if this feature could be activated by just an option in the settings. Is this planned? |
Ok, my annoyance level grew so much that I eventually edited my settings.json accordingly, using "showCloseButton": "activeOnly". I'll see if that works out. Still would prefer a simple selection in the options. |
The "close tab" area is significantly larger than just the visible It's way too easy to accidentally click "close" even when you give yourself extra margin, especially with no close tab confirmation. Please, as @mreymann suggested, just make this a simple setting to change (without needing to create a whole new theme) -- and preferably, add a confirmation the first few times for new Sticking with ConEmu in the meantime. |
Yes, This thread has been really useful in figuring out how to write the JSON. Thanks. I went with the minimal approach as well, just to get the feature working. Exposing it in the settings UI as well would be a welcome addition. |
Add a setting to hide/remove close ("x") button from tabs
Issue Details:
Given that the size of tabs can change depending on each tab's title, attempting to use the mouse to change the current tab is fraught with danger: if a title suddenly changes, then you may end up hitting the close-tab button instead of switching.
Fix Details:
A possible solution to this is an option (disabled by default) to hide the close button for all tabs: users can still close tab with middle-click or Ctrl+W (or whatever hotkey they've set), but there is no risk of accidentally hitting the close button, with the added bonus of reducing the size of each tab.
NOTE: There are a number of other possible fixes for the problem I've described above (including "Restore closed tab" #960, "Confirmation prompt when closing a tab" #2976 and "Keep the width of tabs the same while the user is hovering over the tab bar"), but those are out-of-scope for this request.
The text was updated successfully, but these errors were encountered: