Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to confirm before closing a tab #9470

Closed
ercius opened this issue Mar 12, 2021 · 5 comments
Closed

Option to confirm before closing a tab #9470

ercius opened this issue Mar 12, 2021 · 5 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@ercius
Copy link

ercius commented Mar 12, 2021

Description of the new feature/enhancement

I accidentally clicked the x on a running Ubuntu terminal (instead of activating that tab) and closed an important ssh session losing all work. There was no confirmation to close the running session.

Can an option to confirm on exit for a single tab be added? There is already an option to confirm when closing many tabs, but not for a single tab.

BTW: Windows Terminal is awesome. Where has this been all my life?

@ercius ercius added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 12, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 12, 2021
@Nacimota
Copy link
Contributor

This seems pretty reasonable to me as an optional feature, disabled by default. Perhaps we could even have it as a per-profile setting? So for instance if you have a profile you mostly use for SSH or something important you don't want to accidentally close you could set warnOnClose (or whatever) to true.

@Don-Vito
Copy link
Contributor

@Nacimota - great idea.

@ercius - consider using read-only panes for important stuff (https://docs.microsoft.com/en-us/windows/terminal/customize-settings/actions#mark-a-pane-as-read-only-preview).

In addition, there is #3335, suggesting to hide the "x" button to prevent such faulty clicks.

@ercius
Copy link
Author

ercius commented Mar 14, 2021

warnOnClose is a great option to have per tab.

Ill also check out the read-only panes in Preview and see how they work. Thanks!

@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #6549 for more discussion.

/dup #6549

@ghost
Copy link

ghost commented Mar 15, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 15, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 15, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants