Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor: Revision - Add 'monitor/' prefix to monitor metrics in result summary #274

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

yukirora
Copy link
Contributor

Description
Add 'monitor/' prefix to monitor metrics in result summary.

@yukirora yukirora added runner SuperBench Runner monitor labels Dec 23, 2021
@yukirora yukirora requested a review from a team as a code owner December 23, 2021 03:51
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #274 (7fd809f) into release/0.4 (6ecded2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/0.4     #274   +/-   ##
============================================
  Coverage        87.65%   87.66%           
============================================
  Files               75       75           
  Lines             4359     4360    +1     
============================================
+ Hits              3821     3822    +1     
  Misses             538      538           
Flag Coverage Δ
cpu-unit-test 71.86% <100.00%> (+<0.01%) ⬆️
cuda-unit-test 87.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/runner/runner.py 86.80% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ecded2...7fd809f. Read the comment docs.

superbench/runner/runner.py Outdated Show resolved Hide resolved
Co-authored-by: Yifan Xiong <yifan.xiong@microsoft.com>
@cp5555 cp5555 removed their request for review December 23, 2021 15:35
@cp5555 cp5555 enabled auto-merge (squash) December 23, 2021 15:36
@cp5555 cp5555 merged commit 3d8721a into release/0.4 Dec 23, 2021
@cp5555 cp5555 deleted the v-yutjiang/monitor-prefix branch December 23, 2021 15:56
abuccts pushed a commit that referenced this pull request Dec 29, 2021
…t summary (#274)

**Description**
Add 'monitor/' prefix to monitor metrics in result summary.
abuccts added a commit that referenced this pull request Dec 30, 2021
__Description__

Cherry-pick  bug fixes from v0.4.0 to main.

__Major Revisions__

* Bug - Fix issues for Ansible and benchmarks (#267)
* Tests - Refine test cases for microbenchmark (#268)
* Bug - Build openmpi with ucx support in rocm dockerfiles (#269)
* Benchmarks: Fix Bug - Fix fio build issue (#272)
* Docs - Unify metric and add doc for cublas and cudnn functions (#271)
* Monitor: Revision - Add 'monitor/' prefix to monitor metrics in result summary (#274)
* Bug - Fix bug of detecting if gpu_index is none (#275)
* Bug - Fix bugs in data diagnosis (#273)
* Bug - Fix issue that the root mpi rank may not be the first in the hostfile (#270)
* Benchmarks: Configuration - Update inference and network benchmarks in configs (#276)
* Docs - Upgrade version and release note (#277)

Co-authored-by: Yuting Jiang <v-yutjiang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitor runner SuperBench Runner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants