Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Fix bugs in data diagnosis #273

Merged
merged 5 commits into from
Dec 24, 2021
Merged

Conversation

yukirora
Copy link
Contributor

Description
Fix bugs in data diagnosis.

Major Revision

  • fix package import issue of file_handler
  • deal with monitor metrics
  • fix typo in output_path

@yukirora yukirora requested a review from a team as a code owner December 21, 2021 13:43
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #273 (77e9551) into release/0.4 (ce1481d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/0.4     #273      +/-   ##
===============================================
+ Coverage        87.77%   87.80%   +0.03%     
===============================================
  Files               75       75              
  Lines             4360     4364       +4     
===============================================
+ Hits              3827     3832       +5     
+ Misses             533      532       -1     
Flag Coverage Δ
cpu-unit-test 72.03% <100.00%> (+0.04%) ⬆️
cuda-unit-test 87.76% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/analyzer/data_diagnosis.py 92.14% <100.00%> (+2.43%) ⬆️
superbench/analyzer/file_handler.py 82.17% <0.00%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce1481d...77e9551. Read the comment docs.

@cp5555 cp5555 added bug Something isn't working tool labels Dec 21, 2021
@cp5555 cp5555 requested review from abuccts and guoshzhao December 21, 2021 21:36
superbench/analyzer/data_diagnosis.py Outdated Show resolved Hide resolved
superbench/analyzer/data_diagnosis.py Outdated Show resolved Hide resolved
superbench/analyzer/data_diagnosis.py Outdated Show resolved Hide resolved
tests/analyzer/test_data_diagnosis.py Outdated Show resolved Hide resolved
tests/analyzer/test_data_diagnosis.py Outdated Show resolved Hide resolved
tests/analyzer/test_data_diagnosis.py Show resolved Hide resolved
tests/analyzer/test_data_diagnosis.py Outdated Show resolved Hide resolved
tests/analyzer/test_data_diagnosis.py Outdated Show resolved Hide resolved
@cp5555 cp5555 assigned abuccts and unassigned guoshzhao Dec 23, 2021
@abuccts abuccts enabled auto-merge (squash) December 24, 2021 04:37
@abuccts abuccts merged commit bcf6ea3 into release/0.4 Dec 24, 2021
@abuccts abuccts deleted the v-yutjiang@diagnosis-fix branch December 24, 2021 05:33
abuccts pushed a commit that referenced this pull request Dec 29, 2021
**Description**
Fix bugs in data diagnosis.

**Major Revision**
- fix package import issue of file_handler
- deal with monitor metrics
- fix typo in output_path
abuccts added a commit that referenced this pull request Dec 30, 2021
__Description__

Cherry-pick  bug fixes from v0.4.0 to main.

__Major Revisions__

* Bug - Fix issues for Ansible and benchmarks (#267)
* Tests - Refine test cases for microbenchmark (#268)
* Bug - Build openmpi with ucx support in rocm dockerfiles (#269)
* Benchmarks: Fix Bug - Fix fio build issue (#272)
* Docs - Unify metric and add doc for cublas and cudnn functions (#271)
* Monitor: Revision - Add 'monitor/' prefix to monitor metrics in result summary (#274)
* Bug - Fix bug of detecting if gpu_index is none (#275)
* Bug - Fix bugs in data diagnosis (#273)
* Bug - Fix issue that the root mpi rank may not be the first in the hostfile (#270)
* Benchmarks: Configuration - Update inference and network benchmarks in configs (#276)
* Docs - Upgrade version and release note (#277)

Co-authored-by: Yuting Jiang <v-yutjiang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants