Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git should recreate 'gvfs.sharedCache` when it's missing, and re-enable MountReusesLocalCacheKeyWhenGitObjectsRootDeleted test #147

Closed
wilbaker opened this issue Oct 3, 2019 · 0 comments · Fixed by #165
Closed

Git should recreate 'gvfs.sharedCache` when it's missing, and re-enable MountReusesLocalCacheKeyWhenGitObjectsRootDeleted test #147

wilbaker opened this issue Oct 3, 2019 · 0 comments · Fixed by #165

Comments

@wilbaker
Copy link
Member

wilbaker commented Oct 3, 2019

MountReusesLocalCacheKeyWhenGitObjectsRootDeleted has been disabled as part of #146 and git complains that the git object root is missing:

1) Failed : Scalar.FunctionalTests.Tests.MultiEnlistmentTests.SharedCacheTests.MountReusesLocalCacheKeyWhenGitObjectsRootDeleted()
  error: object directory /Users/wilbaker/Scalar.FT/a87de00dea774ff489213160f1141ebd/.customScalarCache/6d2753dc562f49819b5026e687e9c02f does not exist; check .git/objects/info/alternates

Assuming that we still want this scenario to work with git, the gvfs.sharedCache directory should be recreated if its missing.

Note: It's possible this is already fixed with the changes in #122
@wilbaker wilbaker changed the title Re-enable MountReusesLocalCacheKeyWhenGitObjectsRootDeleted test Git should re-create 'gvfs.sharedCache` when it's missing, and re-enable MountReusesLocalCacheKeyWhenGitObjectsRootDeleted test Oct 4, 2019
@wilbaker wilbaker changed the title Git should re-create 'gvfs.sharedCache` when it's missing, and re-enable MountReusesLocalCacheKeyWhenGitObjectsRootDeleted test Git should recreate 'gvfs.sharedCache` when it's missing, and re-enable MountReusesLocalCacheKeyWhenGitObjectsRootDeleted test Oct 4, 2019
@wilbaker wilbaker mentioned this issue Oct 4, 2019
Merged
@derrickstolee derrickstolee mentioned this issue Oct 9, 2019
Merged
derrickstolee added a commit that referenced this issue Oct 9, 2019
@derrickstolee
Merge pull request #165: Update Git to include gvfs-helper update
9dc5ce8 
See microsoft/git#206 and microsoft/git#207 for the Git updates.

Un-ignore a functional test now that Git is doing the right thing.

Resolves #147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Git to include gvfs-helper update
1 participant
@wilbaker