fixup! gvfs-helper: better handling of network errors #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
derrickstolee
approved these changes
Oct 9, 2019
wilbaker
approved these changes
Oct 9, 2019
derrickstolee
added a commit
to microsoft/scalar
that referenced
this pull request
Oct 9, 2019
See microsoft/git#206 and microsoft/git#207 for the Git updates. Un-ignore a functional test now that Git is doing the right thing. Resolves #147
derrickstolee
pushed a commit
that referenced
this pull request
Jun 1, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 20, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 27, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 28, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 6, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 6, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 9, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 9, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 16, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 19, 2020
mjcheetham
pushed a commit
that referenced
this pull request
Dec 15, 2020
mjcheetham
pushed a commit
that referenced
this pull request
Dec 15, 2020
mjcheetham
pushed a commit
that referenced
this pull request
Jul 23, 2024
mjcheetham
pushed a commit
that referenced
this pull request
Jul 29, 2024
mjcheetham
pushed a commit
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday's commit caused a breakage where gvfs-helper.exe exited (with code 5
aka GH__ERROR_CODE__HTTP_404) when it received a 404 from the HTTP server
rather than just reporting that status code to the git.exe client. This caused the
gvfs-helper.exe process to exit (prematurely) and subsequent GET requests from
git.exe to fail with "packet write with format failed" (because the pipe was half-closed).
Yesterday's commit was intended to ensure that gvfs-helper.exe properly sends "ok",
"partial", or "error msg" back to the client. But inadvertently also returned the "status.ec".
This fix corrects that. We only use "status.ec" to decide which response to send
back to git.exe. And gvfs-helper only exits for hard errors.