Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mount Removal] Improve the layout of files owned by Scalar.Service and audit their ACLs #136

Closed
wilbaker opened this issue Oct 1, 2019 · 2 comments
Closed

[Mount Removal] Improve the layout of files owned by Scalar.Service and audit their ACLs #136

wilbaker opened this issue Oct 1, 2019 · 2 comments
Labels
disk-layout Issues that impact the disk layout used by Scalar no-activity Stale issue or PR that will be automatically closed soon.
Milestone
MVP

Comments

@wilbaker
Copy link
Member

wilbaker commented Oct 1, 2019 •
edited
Loading

Currently the service config file lives in the root of the Scalar folder (in ProgramData) which makes getting the ACLs right very difficult. It should be moved to a subfolder, and we should review the layout of the other files.

As part of this work look for TODO's that mention #136 in the code.
@wilbaker wilbaker added the disk-layout Issues that impact the disk layout used by Scalar label Oct 2, 2019
@derrickstolee derrickstolee mentioned this issue Oct 3, 2019
Merged
@derrickstolee derrickstolee added this to the MVP milestone Oct 4, 2019
derrickstolee added a commit that referenced this issue Oct 4, 2019
@derrickstolee
Merge pull request #122: Use GVFS Helper transport instead of read ob…
a8b0b08 
…ject hook

See microsoft/git#191 for the Git code regarding the GVFS transport layer. This can work in tandem with the read-object hook, but it _should_ make the read-object hook irrelevant.

* Delete all references to the read-object hook in the product code. This unblocks #4 and the [Mount Removal] tasks #15,  #132, #133, #135, #136, and possible others.

* Delete the Sparse Verb in favor of `git sparse-checkout set`.

* Delete the `BlobPrefetcher` and all references to `--files` or `--folders` prefetching.

Resolves #6, #7, #36.
@wilbaker wilbaker changed the title [Mount Removal] Improve the layout of files owned by Scalar.Service [Mount Removal] Improve the layout of files owned by Scalar.Service and audit their ACLs Oct 11, 2019
@github-actions
Copy link

github-actions bot commented Dec 4, 2019

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Dec 4, 2019
@wilbaker wilbaker removed the no-activity Stale issue or PR that will be automatically closed soon. label Dec 4, 2019
@github-actions
Copy link

github-actions bot commented Jan 4, 2020

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
disk-layout Issues that impact the disk layout used by Scalar no-activity Stale issue or PR that will be automatically closed soon.
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
2 participants
@derrickstolee @wilbaker