Add isReverted to DOM Selection
#2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
requested review from
flyingbee2012,
JiuqingSong,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
JiuqingSong
reviewed
Jan 29, 2024
packages-content-model/roosterjs-content-model-types/lib/parameter/Position.ts
Outdated
Show resolved
Hide resolved
packages-content-model/roosterjs-content-model-core/lib/coreApi/getDOMSelection.ts
Show resolved
Hide resolved
packages-content-model/roosterjs-content-model-dom/lib/domUtils/getFocusedPosition.ts
Outdated
Show resolved
Hide resolved
…icrosoft/roosterjs into u/bvalverde/addFocusedPosition
BryanValverdeU
changed the title
isReverted to DOM Selection
JiuqingSong
reviewed
Jan 30, 2024
| @@ -27,6 +27,7 @@ export function contentModelToDom( | |||
| onNodeCreated?: OnNodeCreated | |||
| ): DOMSelection | null { | |||
| context.onNodeCreated = onNodeCreated; | |||
| context.regularSelection.isReverted = isSelectionReverted(doc.getSelection()); | |||
There was a problem hiding this comment.
selection in content model may not be the same with current selection, so here we can't use doc.getSelection().
Actually when create Content Model, I think the isReverted info is lost, because we only have "isSelected" in Content Model but we don't store if it is reverted.
Do we need this info when write back from Content Model? If not, we can always set to false and leave a TODO here.
There was a problem hiding this comment.
Ok, lets remove it.
The only problem here is that if the selection was reverse of the document, after model to dom, the reverse order could be lost. But it is probably a small issue.
JiuqingSong
approved these changes
Jan 30, 2024
Andres-CT98
added a commit
that referenced
this pull request
Feb 2, 2024
* wip * wip * refactor * fix dependecies * fix dependecies * fix dependecies * WIP * add test * add tests * types * add comment * add comment * add comment * add comment * add comment * comments * fix build * fixes * fixes * refactor * fixes * Add shortcut support Ctrl+K for insertLink (#2333) * Add shortcut support Ctrl+K for insertLink * Add metakey and alt key checks * Add insertButton check and disable param * add options to ribbon and decouple onButtonClick * update * update fix * add break statement * remove duplicate imports --------- Co-authored-by: Ghanem10 <107857762+Ghanem10@users.noreply.github.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com> * Content Model: Add back ContentModelBeforePasteEvent (#2347) * Use margin-top and bottom for list margin (#2346) * Standalone Editor: Improve cache (3rd try) (#2344) Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com> * fixes * fix test * Fix safari selection issue (#2332) * try fix safari selection issue * fix content model editor, add test * fix focus bug * Standalone Editor: Remove dependency to old code from api and plugins package (#2349) * Content Model: Decouple test code from old code (#2351) * Fix demo site (#2353) * Content Model: Fix table text color (#2359) * Fix pending format (#2354) * Fix pending format * improve * Standalone Editor: Provide a DOMHelper to allow access DOM tree (#2363) * Fix shadow edit (#2355) * Fix 2 shadow edit issue (#2356) * Support unit "inch" when parse value (#2357) * Content Model: Support inch when parse unit value * add comment * Code clean up: small refactor to paste code (#2365) * Refactor paste * add test * Code clean up: Remove IStandaloneEditor.setContentModel (#2364) * Add support to cursor around Block entities. (#2350) * rotator space * Port ContextMenu plugin (#2366) * Port ContextMenu plugin * add test * Content Model: Fix 252436 (#2367) * Content Model: Fix 252436 * add test --------- Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com> * Code cleanup: Remove parameter onNodeCreated (#2374) * Code cleanup: Remove isContentModelEditor (#2371) * Code cleanup: Remove isContentModelEditor * add buttons * Add `isReverted` to DOM Selection (#2368) * add Changes * add Tests * fix dependencies * address comments * address comment * fix after merge * fix test --------- Co-authored-by: Jiuqing Song <jisong@microsoft.com> * Code cleanup: Remove NormalizeTablePlugin (#2376) * add normalize content model * fix build * Code cleanup: Replace createContentModel with getContentModelCopy (#2372) * Code cleanup: Remove isContentModelEditor * add buttons * Code cleanup: Replace createContentModel with getContentModelCopy * Code cleanup: Remove get/setZoomScale (#2378) * Code cleanup: Remove get/setZoomScale * Add calculateZoomScale function * improve * Code cleanup: Move isNodeInEditor into DOMHelper (#2379) * Code cleanup: Remove TODO (#2384) * Add write permission to deploy action (#2383) * Revert "Add support to cursor around Block entities. (#2350)" (#2390) This reverts commit 7998d03. * Content Model: Fix #2202 (#2389) Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com> * bump --------- Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com> Co-authored-by: Gani <107857762+gm-al@users.noreply.github.com> Co-authored-by: Ghanem10 <107857762+Ghanem10@users.noreply.github.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com> Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.1. To accomplish this, also adds a new property to DOMSelection
isRevertedto determine if the selection in the DOM was in Document order (From right to left/Top to bottom) or in reverse Document order (Left to right/Bottom to top). By Checking the Focus node of the selection and the start container of the range of the selection.