Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2 shadow edit issue #2356

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Fix 2 shadow edit issue #2356

merged 3 commits into from
Jan 25, 2024

Conversation

JiuqingSong
Copy link
Collaborator

  1. Shadow edit with one drop down, then directly go to another drop down, shadow edit will not work: https://outlookweb.visualstudio.com/Outlook%20Web/_queries/edit/247916/?triage=true
  2. Shadow edit will be auto applied when editor is in table selection: https://outlookweb.visualstudio.com/Outlook%20Web/_queries/edit/235389/?triage=true

Fix:

  1. Always restore selection to editor core when turn off shadow edit, so when go to next shadow edit, selection can still be correctly retrieved
  2. Remove the code handling table selection for shadow editor from TableCellSelection plugin. @BryanValverdeU please take a look here if it is ok.

@JiuqingSong JiuqingSong merged commit 7018043 into master Jan 25, 2024
7 checks passed
@JiuqingSong JiuqingSong deleted the u/jisong/shadowbug2 branch January 25, 2024 20:59
Andres-CT98 added a commit that referenced this pull request Feb 2, 2024
@Andres-CT98 @juliaroldi
@ganialhamad @JiuqingSong @BryanValverdeU
Version bump content model packages to 0.25.0 (#2392)
fb93567 
* wip

* wip

* refactor

* fix dependecies

* fix dependecies

* fix dependecies

* WIP

* add test

* add tests

* types

* add comment

* add comment

* add comment

* add comment

* add comment

* comments

* fix build

* fixes

* fixes

* refactor

* fixes

* Add shortcut support Ctrl+K for insertLink  (#2333)

* Add shortcut support Ctrl+K for insertLink

* Add metakey and alt key checks

* Add insertButton check and disable param

* add options to ribbon and decouple onButtonClick

* update

* update fix

* add break statement

* remove duplicate imports

---------

Co-authored-by: Ghanem10 <107857762+Ghanem10@users.noreply.github.com>
Co-authored-by: Jiuqing Song <jisong@microsoft.com>

* Content Model: Add back ContentModelBeforePasteEvent (#2347)

* Use margin-top and bottom for list margin (#2346)

* Standalone Editor: Improve cache (3rd try) (#2344)

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* fixes

* fix test

* Fix safari selection issue (#2332)

* try fix safari selection issue

* fix content model editor, add test

* fix focus bug

* Standalone Editor: Remove dependency to old code from api and plugins package (#2349)

* Content Model: Decouple test code from old code (#2351)

* Fix demo site (#2353)

* Content Model: Fix table text color (#2359)

* Fix pending format (#2354)

* Fix pending format

* improve

* Standalone Editor: Provide a DOMHelper to allow access DOM tree (#2363)

* Fix shadow edit (#2355)

* Fix 2 shadow edit issue (#2356)

* Support unit "inch" when parse value (#2357)

* Content Model: Support inch when parse unit value

* add comment

* Code clean up: small refactor to paste code (#2365)

* Refactor paste

* add test

* Code clean up: Remove IStandaloneEditor.setContentModel (#2364)

* Add support to cursor around Block entities. (#2350)

* rotator space

* Port ContextMenu plugin (#2366)

* Port ContextMenu plugin

* add test

* Content Model: Fix 252436 (#2367)

* Content Model: Fix 252436

* add test

---------

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Code cleanup: Remove parameter onNodeCreated (#2374)

* Code cleanup: Remove isContentModelEditor (#2371)

* Code cleanup: Remove isContentModelEditor

* add buttons

* Add `isReverted` to DOM Selection (#2368)

* add Changes

* add Tests

* fix dependencies

* address comments

* address comment

* fix after merge

* fix test

---------

Co-authored-by: Jiuqing Song <jisong@microsoft.com>

* Code cleanup: Remove NormalizeTablePlugin (#2376)

* add normalize content model

* fix build

* Code cleanup: Replace createContentModel with getContentModelCopy (#2372)

* Code cleanup: Remove isContentModelEditor

* add buttons

* Code cleanup: Replace createContentModel with getContentModelCopy

* Code cleanup: Remove get/setZoomScale (#2378)

* Code cleanup: Remove get/setZoomScale

* Add calculateZoomScale function

* improve

* Code cleanup: Move isNodeInEditor into DOMHelper (#2379)

* Code cleanup: Remove TODO (#2384)

* Add write permission to deploy action (#2383)

* Revert "Add support to cursor around Block entities. (#2350)" (#2390)

This reverts commit 7998d03.

* Content Model: Fix #2202 (#2389)

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* bump

---------

Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Gani <107857762+gm-al@users.noreply.github.com>
Co-authored-by: Ghanem10 <107857762+Ghanem10@users.noreply.github.com>
Co-authored-by: Jiuqing Song <jisong@microsoft.com>
Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanValverdeU BryanValverdeU BryanValverdeU approved these changes

@flyingbee2012 flyingbee2012 Awaiting requested review from flyingbee2012

@ianeli1 ianeli1 Awaiting requested review from ianeli1

@vinguyen12 vinguyen12 Awaiting requested review from vinguyen12

@juliaroldi juliaroldi Awaiting requested review from juliaroldi

@Andres-CT98 Andres-CT98 Awaiting requested review from Andres-CT98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiuqingSong @BryanValverdeU