Make react-native-macos a monorepo #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#36434 Changelog: [Internal] This is a squashed stack of 18 commits, starting from D43202126 allow-large-files Reviewed By: cortinico Differential Revision: D43977381 fbshipit-source-id: 0da552ddb85f2f61a0be0ef071915b35f3f8555c
Saadnajmi
reviewed
Aug 17, 2023
added 3 commits
August 17, 2023 15:58
Summary: Pull Request resolved: facebook#37571 During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup. This change tries to re-enable them so we can be more protected in CI [internal] - Re-enable integration tests Reviewed By: cortinico Differential Revision: D46178840 fbshipit-source-id: a5239fa7067b8fb68d997dd0cc63b67fb54d2d7e
Saadnajmi
reviewed
Aug 18, 2023
Saadnajmi
reviewed
Aug 18, 2023
Saadnajmi
reviewed
Aug 18, 2023
Saadnajmi
approved these changes
Aug 18, 2023
Saadnajmi
reviewed
Aug 22, 2023
Saadnajmi
reviewed
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This merges 714b502 into our repo, but we had to take a few extra steps.
We first moved all the relevant files and folders that were moved as part of the original change since just merging directly could have missed macOS-specific files. Everything else is adjusting things so RNTester works. This includes applying facebook#36582 as a forward fix.
Changelog
[INTERNAL]
Test Plan
RNTester works.
We also want to make sure that our CIs pass. As of 919a0cc there may be quite a bit of churn in our CI scripts, but we can fix these as needed before checking in.