Re-enable iOS integration tests #37571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46178840 |
Base commit: 1a1e399 |
|
This pull request was exported from Phabricator. Differential Revision: D46178840 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37571 During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup. This change tries to re-enable them so we can be more protected in CI ## Changelog: [internal] - Re-enable integration tests Reviewed By: cortinico Differential Revision: D46178840 fbshipit-source-id: 5b735a5e2e4087b1f06e3de185fa50631fc98cb4
cipolleschi
force-pushed
the
export-D46178840
branch
2 times, most recently
from
2c2204e
to
6701f2a
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37571 During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup. This change tries to re-enable them so we can be more protected in CI ## Changelog: [internal] - Re-enable integration tests Reviewed By: cortinico Differential Revision: D46178840 fbshipit-source-id: 591732585fa49fbd177c38c5e339b7a5fba5a97c
|
This pull request was exported from Phabricator. Differential Revision: D46178840 |
Summary: Pull Request resolved: facebook#37571 During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup. This change tries to re-enable them so we can be more protected in CI ## Changelog: [internal] - Re-enable integration tests Reviewed By: cortinico Differential Revision: D46178840 fbshipit-source-id: e903c0e3ed8a28cd7ef009ae23301b714b333c64
cipolleschi
force-pushed
the
export-D46178840
branch
from
6701f2a
to
f9d42c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46178840 |
|
This pull request has been merged in bdeb09b. |
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#37571 During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup. This change tries to re-enable them so we can be more protected in CI [internal] - Re-enable integration tests Reviewed By: cortinico Differential Revision: D46178840 fbshipit-source-id: a5239fa7067b8fb68d997dd0cc63b67fb54d2d7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup.
This change tries to re-enable them so we can be more protected in CI
Changelog:
[internal] - Re-enable integration tests
Differential Revision: D46178840