Skip to content

Commit

Permalink
Re-enable iOS integration tests (#37571)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #37571

During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup.

This change tries to re-enable them so we can be more protected in CI

## Changelog:
[internal] - Re-enable integration tests

Reviewed By: cortinico

Differential Revision: D46178840

fbshipit-source-id: 5b735a5e2e4087b1f06e3de185fa50631fc98cb4
  • Loading branch information
cipolleschi authored and facebook-github-bot committed May 25, 2023
1 parent 992c45c commit 2c2204e
Show file tree
Hide file tree
Showing 24 changed files with 3 additions and 6 deletions.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes
1 change: 0 additions & 1 deletion packages/rn-tester/RNTester/RNTester.xctestplan
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
},
"testTargets" : [
{
"enabled": false,
"target" : {
"containerPath" : "container:RNTesterPods.xcodeproj",
"identifier" : "E7DB215222B2F332005AC45F",
Expand Down
8 changes: 3 additions & 5 deletions scripts/objc-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ xcbeautifyFormat() {
}

preloadBundlesRNIntegrationTests() {
# Preload IntegrationTests bundles (/)
# TODO(T149119847): These need to be relocated into a dir with a Metro config
# Preload IntegrationTests bundles (packages/rn-tester/)
curl -s 'http://localhost:8081/IntegrationTests/IntegrationTestsApp.bundle?platform=ios&dev=true' -o /dev/null
curl -s 'http://localhost:8081/IntegrationTests/RCTRootViewIntegrationTestApp.bundle?platform=ios&dev=true' -o /dev/null
}
Expand All @@ -127,15 +126,14 @@ main() {

# Start the WebSocket test server
echo "Launch WebSocket Server"
sh "$ROOT/IntegrationTests/launchWebSocketServer.sh" &
sh "./IntegrationTests/launchWebSocketServer.sh" &
waitForWebSocketServer

# Start the packager
yarn start --max-workers=1 || echo "Can't start packager automatically" &
waitForPackager
preloadBundlesRNTester
# TODO(T149119847)
# preloadBundlesRNIntegrationTests
preloadBundlesRNIntegrationTests

# Build and run tests.
if [ -x "$(command -v xcbeautify)" ]; then
Expand Down

0 comments on commit 2c2204e

Please sign in to comment.