[Fabric] Shim RCTTextInput #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Jan 24, 2023
React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
Show resolved
Hide resolved
Saadnajmi
reviewed
Jan 24, 2023
React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
Show resolved
Hide resolved
Saadnajmi
reviewed
Jan 24, 2023
There was a problem hiding this comment.
Note: This might change a bit with 0.71 because 0.71 introduced this commit (facebook#33653) that conflicts with some of the macOS specific changes we made to TextInput (#1423). So this PR might be worth holding off till after 0.71.
Once we have Fabric building, we plan to revisit TextInput in depth & use the latest Fabric changes. |
Saadnajmi
approved these changes
Jan 25, 2023
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm # React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputUtils.h # React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputUtils.mm
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm # React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputUtils.h # React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputUtils.mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fabric on macOS implementation:
Shim RCTTextInput to work w/ Fabric
closes #1547
Changelog
[macOS][Added] - Shim RCTTextInput for Fabric
Test Plan
[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no RCTTextInput errors
[x] Build RNTester - iOS w/ Fabric
[x] Build RNTester-macOS w/ Paper - should work
[x] Build RNTester - iOS w/ Paper -
