Adds declarative props to clear/submit MultilineTextInput #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophpurrer
force-pushed
the
keydownSubmit
branch
from
a8c73a6 to
7f16d8a
Compare
christophpurrer
commented
Sep 8, 2022
christophpurrer
commented
Sep 8, 2022
christophpurrer
commented
Sep 8, 2022
christophpurrer
force-pushed
the
keydownSubmit
branch
4 times, most recently
from
4728795 to
3f9ac1c
Compare
Saadnajmi
reviewed
Sep 20, 2022
christophpurrer
force-pushed
the
keydownSubmit
branch
from
3f9ac1c to
5d7042e
Compare
This brings macOS parity with react-native-windows microsoft/react-native-windows#7333 for MultilineTextInput fields See react-native-windows PR for desired feature set. We can't do it for SinglelineTextInput fields (at least not w/o hacks) as it does not support overriding the keyDown event :-( https://stackoverflow.com/a/6076492
christophpurrer
force-pushed
the
keydownSubmit
branch
from
5d7042e to
2fb18dd
Compare
|
Awesome feedback. Screen.Recording.2022-09-20.at.10.38.35.PM.mov |
Saadnajmi
approved these changes
Sep 21, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…1423) This brings macOS parity with react-native-windows microsoft/react-native-windows#7333 for MultilineTextInput fields See react-native-windows PR for desired feature set. We can't do it for SinglelineTextInput fields (at least not w/o hacks) as it does not support overriding the keyDown event :-( https://stackoverflow.com/a/6076492 Co-authored-by: Alex Chiu <ackchiu@fb.com> # Conflicts: # Libraries/Components/TextInput/TextInput.js # Libraries/Text/TextInput/RCTBackedTextInputDelegate.h # Libraries/Text/TextInput/RCTBaseTextInputView.h # Libraries/Text/TextInput/RCTBaseTextInputView.m # Libraries/Text/TextInput/RCTBaseTextInputViewManager.m
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…1423) This brings macOS parity with react-native-windows microsoft/react-native-windows#7333 for MultilineTextInput fields See react-native-windows PR for desired feature set. We can't do it for SinglelineTextInput fields (at least not w/o hacks) as it does not support overriding the keyDown event :-( https://stackoverflow.com/a/6076492 Co-authored-by: Alex Chiu <ackchiu@fb.com> # Conflicts: # Libraries/Components/TextInput/TextInput.js # Libraries/Text/TextInput/RCTBackedTextInputDelegate.h # Libraries/Text/TextInput/RCTBaseTextInputView.h # Libraries/Text/TextInput/RCTBaseTextInputView.m # Libraries/Text/TextInput/RCTBaseTextInputViewManager.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This brings macOS parity with react-native-windows microsoft/react-native-windows#7333 for MultilineTextInput fields See react-native-windows PR for desired feature set.
We can't do it for SinglelineTextInput fields (at least not w/o hacks) as it does not support overriding the keyDown event :-( https://stackoverflow.com/a/6076492
Changelog
[macOS] [Added] - Adds declarative props to clear/submit MultilineTextInput
Test Plan
Screen.Recording.2022-09-08.at.12.46.13.PM.mov