Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.66] Add back RCTDynamicColor, but remove references #1062

Merged
2 commits merged into from
Mar 3, 2022
Merged

[0.66] Add back RCTDynamicColor, but remove references #1062

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcb3cea
[0.66] Remove references to RCTDynamicColor
Saadnajmi Mar 2, 2022
0416e22
Add back RCTDynamicColor
Saadnajmi Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/rn-tester/RNTesterUnitTests/RCTConvert_NSColorTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#import <XCTest/XCTest.h>

#import <React/RCTConvert.h>
#import <React/RCTDynamicColor.h>

@interface RCTConvert_NSColorTests : XCTestCase

Expand Down Expand Up @@ -85,7 +84,6 @@ - (void)testDynamicColor
// 16777215 == 0x00FFFFFF == white
id json = RCTJSONParse(@"{ \"dynamic\": { \"light\":0, \"dark\":16777215 } }", nil);
NSColor *value = [RCTConvert UIColor:json];
XCTAssertTrue([value isKindOfClass:[RCTDynamicColor class]]);
CGFloat r, g, b, a;

[NSAppearance setCurrentAppearance:[NSAppearance appearanceNamed:NSAppearanceNameAqua]];
Expand All @@ -109,7 +107,6 @@ - (void)testCompositeDynamicColor
{
id json = RCTJSONParse(@"{ \"dynamic\": { \"light\": { \"semantic\": \"systemRedColor\" }, \"dark\":{ \"semantic\": \"systemBlueColor\" } } }", nil);
NSColor *value = [RCTConvert UIColor:json];
XCTAssertTrue([value isKindOfClass:[RCTDynamicColor class]]);
CGFloat r1, g1, b1, a1;
CGFloat r2, g2, b2, a2;

Expand Down