Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.66] Add back RCTDynamicColor, but remove references #1062

Merged
2 commits merged into from
Mar 3, 2022

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Mar 2, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

EDIT: Due to integration issues, I'll need to add back the RCTDynamicColor class to 0.66 as downstream components reference it.

(Same as #1060 but ported to 0.66-stable)
In #1028 I removed RCTDynamicColor.h/.m . There was still an explicit reference to the class in our unit tests. I'm not sure why that wasn't caught.

Changelog

[macOS] [Fixed] - Removed reference to RCTDynamicColor in our unit tests.

Test Plan

CI should pass.

@Saadnajmi Saadnajmi requested a review from alloy as a code owner March 2, 2022 22:27
@pull-bot
Copy link

pull-bot commented Mar 2, 2022

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS against 0416e22

@Saadnajmi Saadnajmi requested a review from a team March 2, 2022 22:45
@Saadnajmi Saadnajmi changed the title [0.66] Remove references to RCTDynamicColor [0.66] Add back RCTDynamicColor, but remove references Mar 3, 2022
@ghost
Copy link

ghost commented Mar 3, 2022

Hello @Saadnajmi!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 173ed48 into microsoft:0.66-stable Mar 3, 2022
@Saadnajmi Saadnajmi deleted the dynamic-color-fallout-66 branch March 3, 2022 01:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants