Add react-native@0.60 and above support

[alexandergoncharov-zz]

• Add react-native.config.js
• Update docs for setup new react-native versions
• Continue keeping rnpm section in package.json for back-compatibility with React Native version < 0.59

[RodolfoGS]

What is the reason to use react-native.config.js? I'm not using that and works.

[joseph-d-p]

@RodolfoGS it is used for migration from rnpm. RNPM is deprecated.

[joseph-d-p]

@alexandergoncharov link hooks not anymore needed? Referenced the PRs related to this.

[builtbyproxy]

😍 @alexandergoncharov thanks for this, did you miss #1645
The docs are amazing! Any preference or input on the different configs?

[MatthewPattell]

@alexandergoncharov how to use configuration with public key (fourth argument)?

On RN 0.59, it looks like this:

packages.add(new CodePush(BuildConfig.CODEPUSH_KEY_ANDROID, getApplicationContext(), isDebug(), R.string.CODEPUSH_PUBLIC_KEY));

[giacomocerquone]

@MatthewPattell please, this is a PR! If you need help for something open an Issue.

PS: when you execute react-native link react-native-code-push it adds that line for you automatically asking you for the deployment key. But I do always advice to set the key in the js code. For more info see this article of mine :) https://giacomocerquone.com/blog/microsoft-codepush-integration-in-react-native-0.60

[giacomocerquone]

@alexandergoncharov hi, thanks for the work you're doing.
One quick question, considering that putting the deployment key in the native side is a facultative step, would you consider adding in the new docs a simple reminder of the possibility to put it in the js side of things (inside the codepush HoC)

[MatthewPattell]

@MatthewPattell please, this is a PR! If you need help for something open an Issue.

PS: when you execute react-native link react-native-code-push it adds that line for you automatically asking you for the deployment key. But I do always advice to set the key in the js code. For more info see this article of mine :) https://giacomocerquone.com/blog/microsoft-codepush-integration-in-react-native-0.60

Look carefully at the question! I asked about the public key, not deployment

[zanechua]

Does this PR work with multi-deployment? From what I am looking at the moment with the code changes. It doesn't seem to support multi deployment for android or am i mistaken?

The following docs changed that I requested a month and a half back at MicrosoftDocs/appcenter-docs#767 does resolve this though.

[alexandergoncharov-zz]

Hi @zanechua ,
Thanks for this comment. Good catch!

Your approach is really good. Could you please create PR to current branch with your changes about multi-testing deployment? It will be cool to have this changes in current PR.

[alexandergoncharov-zz]

Hi @joseph-d-p,

Unfortunatelly hooks doesn't work anymore and users have to change some part of code manually.
Here is more info: react-native-community/cli#429
Fortunately, some steps already will be done by autolinker.

[zanechua]

@alexandergoncharov Created the pull request to the migrate-to-autolink branch with the multi-deployment docs change for android.

#1738

[alexandergoncharov-zz]

Hi @MatthewPattell ,

Good catch! Thanks!
Since it isn't possible to use a custom constructor with autolinker, we will change the constructor logic by automatically getting the public key from the strings and enabling code signing. The same situation with serverUrl field. To do this we will open separate PR.

[alexandergoncharov-zz]

Hi @giacomocerquone,

Thanks for this suggestion!
Added this note in Android and Ios setup docs.

[JeremyBradshaw7]

I'm still confused about the Android setup for RN 0.61. Is it enough to follow ONLY the section:
Plugin Installation and Configuration for React Native 0.60 version and above

Or do you ALSO have to do the lower sections:
Plugin Configuration (Android)
For React Native >= v0.29
and
Code Signing setup
?

[builtbyproxy]

@alexandergoncharov
This is huge thanks a lot!!
Could you please ensure it is also published to NPM: https://www.npmjs.com/package/react-native-code-push

[alexandergoncharov-zz]

Hi @builtbyproxy ,

Thank you!
We will publish new version to npm as soon as we fix issues with custom variables(publicKey and serverUrl).

[alexandergoncharov-zz]

Hi @JeremyBradshaw7,

Yeah, Plugin Installation and Configuration for React Native 0.60 version and above is enough for setup CodePush for new react-native version. Code Signing Setup is optional. But I got your confusing. We prepared new PR for adding more context about react-native versions in titles.
#1739
Could you please review it?

[builtbyproxy]

Do you need any help/testing from us around the custom variables?
Thanks for that documentation clarification for <= 0.59 RN

[alexandergoncharov-zz]

@builtbyproxy , Yeah, we just opened new PR with getting custom properties from string resources: #1740
It would be great if you review and test it.
Please feel free to ask any questions.

Thanks for help!