Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to react native config from deprecated rnpm config. Configured as dependency. #1678

Closed
wants to merge 1 commit into from
Closed

Update to react native config from deprecated rnpm config. Configured as dependency. #1678

wants to merge 1 commit into from

Conversation

joseph-d-p
Copy link

@joseph-d-p joseph-d-p commented Sep 9, 2019 •
edited
Loading

This commit will migrate from the deprecated rnpm to use react-native.config.js.

This resolves the warning:

warn The following packages use deprecated "rnpm" config that will stop working from next release:

This PR configures the library as a dependency.

@msftclas
Copy link

msftclas commented Sep 9, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

This was referenced Sep 9, 2019
Closed
Closed
@forsen
Copy link

forsen commented Oct 1, 2019

Duplicate: #1645

@joseph-d-p
Copy link
Author

@forsen I saw that one before making this PR. This PR is different since this is a dependency not a project.

@forsen
Copy link

forsen commented Oct 3, 2019

Ah. My bad, didn't catch that one. Maybe it's worth mentioning that in the summary?

@joseph-d-p joseph-d-p changed the title Update to react native config from deprecated rnpm config Update to react native config from deprecated rnpm config. Configured as dependency. Oct 3, 2019
@KingAmo
Copy link

KingAmo commented Oct 11, 2019

may i ask when will this pr be merged?

@joseph-d-p
Copy link
Author

joseph-d-p commented Oct 11, 2019 •
edited
Loading

@alexandergoncharov, hope you have time to review this PR. thank you!

namvoeh
namvoeh reviewed Oct 22, 2019
View reviewed changes
react-native.config.js
@@ -0,0 +1,17 @@
module.exports = {
dependency: {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you add dependency here instead using project?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since RNCP is a library not an app.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, thanks for your information

namvoeh
namvoeh approved these changes Oct 24, 2019
View reviewed changes
Copy link

@namvoeh namvoeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help to merge this PR

@oaosman84
Copy link

Is there a reason this isn't getting merged? Probably causing warnings for a lot of people.

Thanks

@sergeymorkovkin
Copy link

Please merge.

@joseph-d-p joseph-d-p mentioned this pull request Dec 3, 2019
Merged
@joseph-d-p
Copy link
Author

See #1735

@joseph-d-p
Copy link
Author

Closing PR in favour of #1735.

@joseph-d-p joseph-d-p closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theill theill theill approved these changes

@tajriant tajriant tajriant approved these changes

@MiloszFilimowski MiloszFilimowski MiloszFilimowski approved these changes

@builtbyproxy builtbyproxy builtbyproxy approved these changes

@namvoeh namvoeh namvoeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.