This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Fix #325: Debuggee no longer terminates #424
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -113,7 +113,6 @@ def vendored(project, root=None): | |
try: | ||
yield root | ||
finally: | ||
#del sys.path[0] | ||
sys.path.remove(root) | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,12 +27,6 @@ | |
import warnings | ||
from xml.sax import SAXParseException | ||
|
||
import _pydevd_bundle.pydevd_constants as pydevd_constants | ||
# Disable this, since we aren't packaging the Cython modules at the moment. | ||
pydevd_constants.CYTHON_SUPPORTED = False | ||
# We limit representation size in our representation provider when needed. | ||
pydevd_constants.MAXIMUM_VARIABLE_REPRESENTATION_SIZE = 2**32 | ||
|
||
import _pydevd_bundle.pydevd_comm as pydevd_comm # noqa | ||
import _pydevd_bundle.pydevd_extension_api as pydevd_extapi # noqa | ||
import _pydevd_bundle.pydevd_extension_utils as pydevd_extutil # noqa | ||
|
@@ -67,6 +61,7 @@ | |
supportsSetExpression=True, | ||
supportsModulesRequest=True, | ||
supportsLogPoints=True, | ||
supportTerminateDebuggee=True, | ||
exceptionBreakpointFilters=[ | ||
{ | ||
'filter': 'raised', | ||
|
@@ -853,7 +848,9 @@ def _handle_disconnect(self, request): | |
self.disconnect_request_event.set() | ||
self._notify_disconnecting(not self._closed) | ||
if not self._closed: | ||
self.close() | ||
# Closing the socket causes pydevd to resume all threads, | ||
# so just terminate the process altogether. | ||
sys.exit(0) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Won't this prevent re-attach? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It will, but in this scenario (launch), there's not supposed to be one - disconnect after launch means terminate debuggee, or at least that's how we have always implemented it so far in the old debugger. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, right, |
||
|
||
def _wait_for_server_thread(self): | ||
if self.server_thread is None: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related, but gets rid of the Cython warning (again).