This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Fix #325: Debuggee no longer terminates #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminate the process immediately instead of closing pydevd socket when disconnecting after launch.
int19h
commented
May 21, 2018
| @@ -13,6 +14,16 @@ | |||
| warnings.warn(msg + ':\n {}'.format('\n '.join(_unvendored))) | |||
|
|
|||
|
|
|||
| # Constants must be set before importing any other pydevd module | |||
There was a problem hiding this comment.
Not related, but gets rid of the Cython warning (again).
| self.close() | ||
| # Closing the socket causes pydevd to resume all threads, | ||
| # so just terminate the process altogether. | ||
| sys.exit(0) |
There was a problem hiding this comment.
Won't this prevent re-attach?
There was a problem hiding this comment.
It will, but in this scenario (launch), there's not supposed to be one - disconnect after launch means terminate debuggee, or at least that's how we have always implemented it so far in the old debugger.
There was a problem hiding this comment.
Ah, right, on_disconnect() doesn't call _handle_disconnect() in the "attach" case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminate the process immediately instead of closing pydevd socket when disconnecting after launch.
(fixes #325)