Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge fetch params on server side #32518

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

mxschmitt
Copy link
Member

This comment has been minimized.

@@ -159,6 +159,11 @@ export abstract class APIRequestContext extends SdkObject {
for (const { name, value } of params.params)
requestUrl.searchParams.append(name, value);
}
if (params.encodedParams) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just requestUrl.search = params.encodedParams?

@mxschmitt mxschmitt merged commit e5d6ee5 into microsoft:main Sep 9, 2024
28 of 29 checks passed
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Test results for "tests 1"

1 failed
❌ [playwright-test] › babel.spec.ts:135:5 › should not transform external

1 flaky ⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live

29591 passed, 638 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants