chore(roll): roll Playwright to 1.48.0-beta-1728034490000 #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Oct 7, 2024
| @@ -280,6 +287,21 @@ def listen(self, factory: http.HTTPFactory) -> None: | |||
|
|
|||
|
|
|||
| class WebSocketProtocol(WebSocketServerProtocol): | |||
| def __init__(self, *args: Any, **kwargs: Any) -> None: | |||
| super().__init__(*args, **kwargs) | |||
| self.events = EventEmitter() | |||
There was a problem hiding this comment.
this basically rewrites onMessage and onClose to an easier to consume pyee event emitter.
dgozman
reviewed
Oct 7, 2024
| @@ -405,7 +404,8 @@ async def _inner_fetch( | |||
| "fetch", | |||
| { | |||
| "url": url, | |||
| "params": params_to_protocol(params), | |||
| "params": object_to_array(params) if isinstance(params, dict) else None, | |||
| "encodedParams": params if isinstance(params, str) else None, | |||
There was a problem hiding this comment.
I haven't seen this change in .net or java roll for some reason. Could you please double check?
There was a problem hiding this comment.
In Java we don't allow passing query params as strings while in JS/Python/.NET we do. There is no .NET roll yet for this release after we moved the merge logic to the server side.
In Java we have:
There was a problem hiding this comment.
I'd rather not do it in the ports to keep the API surface smaller, especially if there is no user request for this.
| from tests.server import Server, WebSocketProtocol | ||
|
|
||
|
|
||
| async def assert_equal( |
There was a problem hiding this comment.
Looks like we need expect.poll() in python :)
Leoawad
reviewed
Oct 9, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2580