chore(client-certificates): rewrite error for unsupported PFX errors #32008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
changed the title
mxschmitt
force-pushed
the
deprecated-pfx-certifiates
branch
from
7b4c116 to
2adc16b
Compare
mxschmitt
commented
Aug 5, 2024
packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Aug 5, 2024
packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
Outdated
Show resolved
Hide resolved
packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
Show resolved
Hide resolved
Test results for "tests 1"1 failed 4 flaky29565 passed, 702 skipped Merge workflow run. |
YusukeIwaki
added a commit
to YusukeIwaki/playwright-ruby-client
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #32007
Relevant commit to review: 7b4c116
This should make #1799 (comment) more clear.