Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Webportal] Remove storage plugin command inject #4016

Merged
merged 7 commits into from
Dec 30, 2019
Merged

[Webportal] Remove storage plugin command inject #4016

merged 7 commits into from
Dec 30, 2019

Conversation

Binyang2014
Copy link
Contributor

@Binyang2014 Binyang2014 commented Dec 13, 2019 •
edited
Loading

When using storage plugin, we will not inject commands into the user command. Just change the extra field in the protocol.
Sample:

extras:
  com.microsoft.pai.runtimeplugin:
    - plugin: teamwiase_storage
      parameters:
        storageConfigNames:
          - PAI_SAHRE  # storage config name provided by admin

Other changes

  • Fix plugin can not be removed bug

@Binyang2014 Binyang2014 marked this pull request as ready for review December 17, 2019 01:56
@Binyang2014 Binyang2014 force-pushed the binyli/storage-front-end branch 2 times, most recently from 30d7844 to 2fc1e64 Compare December 26, 2019 02:33
@Binyang2014 Binyang2014 changed the title Binyli/storage front end [Webportal] Remove storage plugin command inject Dec 26, 2019
@Binyang2014 Binyang2014 merged commit b3f71ac into master Dec 30, 2019
@Binyang2014 Binyang2014 deleted the binyli/storage-front-end branch December 30, 2019 07:59
@Binyang2014 Binyang2014 mentioned this pull request Feb 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunqinzheng sunqinzheng sunqinzheng approved these changes

@debuggy debuggy Awaiting requested review from debuggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Binyang2014 @sunqinzheng