Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

P1 - Job config is modified after it is imported/uploaded/cloned #3823

Closed
yqwang-ms opened this issue Nov 12, 2019 · 5 comments
Closed

P1 - Job config is modified after it is imported/uploaded/cloned #3823

yqwang-ms opened this issue Nov 12, 2019 · 5 comments

Comments

@yqwang-ms
Copy link
Member

yqwang-ms commented Nov 12, 2019

Organization Name:

Short summary about the issue/question:

Import from Submit Job page:
Left original, right after import
image

Import from Submit Job by plugin page:
Left original, right after import
image

User will confuse why just import/upload/clone will change his job config, and concerns if it can also reproduce this job anymore.
Suggest:

  1. The defaulting should only be done after submission phase.
  2. And we should not change user already specified values in any phase.

We should always pay attention to our reproducibility.

Brief what process you are following:

How to reproduce it:

OpenPAI Environment:

  • OpenPAI version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Hardware (e.g. core number, memory size, storage size, GPU type etc.):
  • Others:

Anything else we need to know:

@yqwang-ms yqwang-ms changed the title Job config is modified after it is imported/uploaded/clone Job config is modified after it is imported/uploaded/cloned Nov 12, 2019
@yqwang-ms
Copy link
Member Author

temp workaround: using sdk or cli to submit raw job config yaml

@scarlett2018 scarlett2018 changed the title Job config is modified after it is imported/uploaded/cloned P1 - Job config is modified after it is imported/uploaded/cloned Dec 30, 2019
@scarlett2018 scarlett2018 added this to the Pure K8S Beta Release milestone Dec 30, 2019
@Binyang2014
Copy link
Contributor

After #4016 is merged, we will keep the Yaml contents are equivalent. But may change the order of config sentences.
As discussed, it's acceptable. Close this issue.

@yqwang-ms
Copy link
Member Author

Acceptable in current does not mean we totally solved this. Defaulting should not be done at this phase.

@fanyangCS
Copy link
Contributor

we need a better yaml editor

@scarlett2018
Copy link
Member

  • The defaulting should only be done after submission phase.
    the current validation updated the fields that is empty with default values, should not change users original form.
  • And we should not change user already specified values in any phase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants