Enable CPUINFO for all Windows build #19655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
force-pushed
the
snnn/enable_cpuinfo_for_onecore
branch
from
fef0732 to
d702611
Compare
snnn
changed the title
…snnn/onnxruntime into snnn/enable_cpuinfo_for_onecore
edgchen1
reviewed
Feb 29, 2024
chenfucn
reviewed
Mar 1, 2024
chenfucn
previously approved these changes
Mar 1, 2024
edgchen1
approved these changes
Mar 1, 2024
snnn
added a commit
that referenced
this pull request
Mar 6, 2024
…ging pipeline (#19786) ### Description 1. Upgrade the version from 10.0.19041.0 to 10.0.22621.0. The old one misses some macros that are needed by PyTorch's CPUINFO 2. Also update cmake. ### Motivation and Context In PR #19655 I added CPUINFO to all Windows builds, but forgot to test this pipeline.
zz002
pushed a commit
to zz002/onnxruntime
that referenced
this pull request
Mar 7, 2024
### Description It was disabled in PR microsoft#9065. And the reason was: " api-ms-win-core-kernel32-legacy-*.dll wasn't available in Windows 8 and was added in Windows 10, so cpuinfo breaks our Windows 8 support. I'm disabling it again." We no longer support Windows 8. Therefore we can add CPUINFO back. ### Motivation and Context To make the code simpler. If in any case the library doesn't work as expected, we can submit a PR to their code base and fix it.
zz002
pushed a commit
to zz002/onnxruntime
that referenced
this pull request
Mar 7, 2024
…ging pipeline (microsoft#19786) ### Description 1. Upgrade the version from 10.0.19041.0 to 10.0.22621.0. The old one misses some macros that are needed by PyTorch's CPUINFO 2. Also update cmake. ### Motivation and Context In PR microsoft#19655 I added CPUINFO to all Windows builds, but forgot to test this pipeline.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was disabled in PR #9065. And the reason was:
" api-ms-win-core-kernel32-legacy-*.dll wasn't available in Windows 8 and was added in Windows 10, so cpuinfo breaks our Windows 8 support. I'm disabling it again."
We no longer support Windows 8. Therefore we can add CPUINFO back.
Motivation and Context
To make the code simpler. If in any case the library doesn't work as expected, we can submit a PR to their code base and fix it.