[REBASE&FF] CryptoPkg: Require exact crypto version match #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javagedes
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #1160 +/- ##
==================================================
- Coverage 1.59% 1.44% -0.15%
==================================================
Files 1448 1447 -1
Lines 362500 360384 -2116
Branches 5632 0 -5632
==================================================
- Hits 5776 5204 -572
+ Misses 356617 355180 -1437
+ Partials 107 0 -107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
added
the
type:design-change
## Description Crypto versioning is not currently backwards compatible. This change updates the check to require an exact match of the crypto version. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested N/A ## Integration Instructions N/A
Javagedes
force-pushed
the
require-crypto-version-match
branch
from
4db82f9
to
a324389
Compare
makubacki
approved these changes
Sep 24, 2024
Flickdm
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crypto versioning is not currently backwards compatible. This change updates the check to require an exact match of the crypto version.
Cherry-pick from dev/202405: 34455f5
How This Was Tested
N/A
Integration Instructions
N/A