CryptoPkg: Require exact crypto version match #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Javagedes
force-pushed
the
crypto-no-backwards-compat
branch
from
3c0dff8
to
0807f68
Compare
kenlautner
approved these changes
Sep 23, 2024
VivianNK
approved these changes
Sep 23, 2024
Crypto versioning is not currently backwards compatible. This change updates the check to require an exact match of the crypto version.
Javagedes
force-pushed
the
crypto-no-backwards-compat
branch
from
0807f68
to
650bbda
Compare
makubacki
approved these changes
Sep 23, 2024
makubacki
reviewed
Sep 23, 2024
makubacki
added
the
type:design-change
Javagedes
added a commit
to Javagedes/mu_basecore
that referenced
this pull request
Sep 23, 2024
## Description Crypto versioning is not currently backwards compatible. This change updates the check to require an exact match of the crypto version. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested N/A ## Integration Instructions N/A
Javagedes
added a commit
to Javagedes/mu_basecore
that referenced
this pull request
Sep 24, 2024
## Description Crypto versioning is not currently backwards compatible. This change updates the check to require an exact match of the crypto version. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested N/A ## Integration Instructions N/A
Javagedes
added a commit
that referenced
this pull request
Sep 24, 2024
## Description Crypto versioning is not currently backwards compatible. This change updates the check to require an exact match of the crypto version. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested N/A ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crypto versioning is not currently backwards compatible. This change updates the check to require an exact match of the crypto version.
How This Was Tested
N/A
Integration Instructions
N/A