Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup NavView tests #2771

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

marcelwgn
Copy link
Collaborator

Description

Addresses the unhelpful tests addressed during #2396 and requested here and here

Motivation and Context

Closes #2468

How Has This Been Tested?

Ran the tests in question

Screenshots (if appropriate):

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jun 27, 2020
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcelwgn
Copy link
Collaborator Author

Looks like the C++ compiler ran out of memory.

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor

Looks like the C++ compiler ran out of memory.

@kmahone Is taking a look. This PR will likely fix the issue.

// Go to the navview items.
// Set focus inside page
var focusButton = FindElement.ByName("FocusAnchorButton");
focusButton.SetFocus();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this now needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah i see now.


In reply to: 447890075 [](ancestors = 447890075)

Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters StephenLPeters merged commit e6e5163 into microsoft:master Jun 30, 2020
@StephenLPeters StephenLPeters added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 30, 2020
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup NavigationView tests
4 participants