Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup NavigationView tests #2468

Closed
marcelwgn opened this issue May 18, 2020 · 0 comments · Fixed by #2771
Closed

Cleanup NavigationView tests #2468

marcelwgn opened this issue May 18, 2020 · 0 comments · Fixed by #2771
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-NavigationView NavView control help wanted Issue ideal for external contributors team-Controls Issue for the Controls team

Comments

@marcelwgn
Copy link
Collaborator

Currently there are a few tests which are not that helpful and should be cleaned up or removed:

  • EnsureNoCrashesInHorizontalFlipMenuItemsSource <- Can this be removed or what is the description meaning
  • EnsureNoCrashesInHorizontalFlipMenuItems <- Same as above
  • MenuItemKeyboardInvokeTest <- Should probably be a test
  • CanDoSelectionChangedOfItemTemplate <- `Should probably verify more
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label May 18, 2020
@marcelwgn marcelwgn mentioned this issue May 18, 2020
Merged
@ranjeshj ranjeshj added area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-NavigationView NavView control team-Controls Issue for the Controls team help wanted Issue ideal for external contributors and removed needs-triage Issue needs to be triaged by the area owners labels May 19, 2020
@marcelwgn marcelwgn mentioned this issue Jun 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-NavigationView NavView control help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup NavView tests marcelwgn/microsoft-ui-xaml
3 participants
@marcelwgn @ranjeshj @msft-github-bot