Doesn't allow writing duplicates in bulk writer and corresponding tests #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagraThapar
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Overall looks great, just some minor comments.
Great work @tvaron3 , thanks!!
src/main/java/com/azure/cosmos/kafka/connect/CosmosDBConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/azure/cosmos/kafka/connect/CosmosDBConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/azure/cosmos/kafka/connect/CosmosDBConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/azure/cosmos/kafka/connect/CosmosDBConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/azure/cosmos/kafka/connect/CosmosDBConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/azure/cosmos/kafka/connect/sink/BulkWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/azure/cosmos/kafka/connect/sink/BulkWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/azure/cosmos/kafka/connect/sink/BulkWriter.java
Outdated
Show resolved
Hide resolved
src/test/java/com/azure/cosmos/kafka/connect/sink/BulkWriterTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/azure/cosmos/kafka/connect/sink/BulkWriterTests.java
Outdated
Show resolved
Hide resolved
|
LGTM - nit: can we please add the actual flag in the PR description? |
src/main/java/com/azure/cosmos/kafka/connect/sink/BulkWriter.java
Outdated
Show resolved
Hide resolved
I saw you updated, but I meant show the value that customer will need to update in their config file for the connector - I think its |
|
Theo I changed it again and the value they would need to change is "connect.cosmos.sink.bulk.compression.enabled". |
kushagraThapar
previously approved these changes
Jun 20, 2023
src/main/java/com/azure/cosmos/kafka/connect/CosmosDBConfig.java
Outdated
Show resolved
Hide resolved
Fixed wording of flag in documentation and changelog Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com>
kushagraThapar
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Purpose of PR
The bulk upsert operation will sometimes write data with duplicate id and partition key incorrectly. This change prevents duplicate items to be sent to the bulk upsert operation. It should only send the latest item. The feature is hidden behind a new config that is set to true by default. The flag added is called "connect.cosmos.sink.bulk.compression.enabled".
Observability + Testing
What changes or considerations did you make in relation to observability?
Did you add testing to account for any new or changed work?
I added a unit test and a integration test for the changes I made in the bulkwriter.
Review notes
Issues Closed or Referenced