Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Fixed wording of flag in documentation and changelog

Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com>
  • Loading branch information
tvaron3 and kushagraThapar authored Jun 20, 2023
1 parent 933a77b commit 1ab7933
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## Release History
### 1.10.0-Beta.1 (Unreleased)
#### New Features
* Added option for compression through new config `connect.cosmos.sink.bulk.compression.enabled`. [PR 515](https://github.com/microsoft/kafka-connect-cosmosdb/pull/515)
* Added compression feature to resolve duplicate records in a single batch when consuming from kafka topic in the bulk mode for sink connector through new config `connect.cosmos.sink.bulk.compression.enabled`. [PR 515](https://github.com/microsoft/kafka-connect-cosmosdb/pull/515)

### 1.9.0 (2023-06-19)
#### New Features
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public class CosmosDBConfig extends AbstractConfig {
private static final boolean DEFAULT_COSMOS_SINK_BULK_ENABLED = true;

public static final String COSMOS_SINK_BULK_COMPRESSION_ENABLED_CONF = "connect.cosmos.sink.bulk.compression.enabled";
private static final String COSMOS_SINK_BULK_COMPRESSION_ENABLED_DOC = "Flag to indicate whether Cosmos DB in bulk mode will allow duplicates in the same batch to be written for Sink connector. By default it is true.";
private static final String COSMOS_SINK_BULK_COMPRESSION_ENABLED_DOC = "Flag to indicate whether Cosmos DB in bulk mode will compress and resolve duplicates in the same batch to be written for Sink connector. By default it is true. ";
private static final boolean DEFAULT_COSMOS_SINK_BULK_COMPRESSION_ENABLED = true;

public static final String COSMOS_SINK_MAX_RETRY_COUNT = "connect.cosmos.sink.maxRetryCount";
Expand Down

0 comments on commit 1ab7933

Please sign in to comment.