Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade macos runner image #785

Merged
merged 3 commits into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/pythonapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-24.04, macos-12, windows-2022]
os: [ubuntu-24.04, macos-14, windows-2022]
python-version: ['3.9', '3.10', '3.11']
env:
TVM_VERSION_TAG: v0.17.0
Expand Down Expand Up @@ -68,7 +68,6 @@ jobs:
if: ${{ startsWith(matrix.os, 'macos')}}
run: |
wget https://raw.githubusercontent.com/Homebrew/homebrew-core/fb8323f2b170bd4ae97e1bac9bf3e2983af3fdb0/Formula/libomp.rb
brew unlink libomp
brew install ./libomp.rb
export CC=/usr/bin/clang
export CXX=/usr/bin/clang++
Expand Down
2 changes: 1 addition & 1 deletion tests/test_sklearn_decomposition.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def _fit_model_pca(self, model, precompute=False):

torch_model = hummingbird.ml.convert(model, "torch")
self.assertTrue(torch_model is not None)
np.testing.assert_allclose(model.transform(X_test), torch_model.transform(X_test), rtol=1e-6, atol=2 * 1e-5)
np.testing.assert_allclose(model.transform(X_test), torch_model.transform(X_test), rtol=4 * 1e-4, atol=2 * 1e-4)

# PCA n_components none
def test_pca_converter_none(self):
Expand Down
Loading