-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Upgrade macos runner image #785
Conversation
mshr-h
commented
Jul 25, 2024
•
edited
Loading
edited
- macOS runner 12->14
0916841
to
9dd3265
Compare
Segmentation fault on macos-13 :( https://github.com/microsoft/hummingbird/actions/runs/10092260187/job/27905556470
|
With macos-14, we hit another error. Do we have to be more tolerant? :(
|
35a003b
to
5db4155
Compare
4de436d
to
2946d8b
Compare
All tests have passed. But I changed atol and rtol in tests/test_sklearn_decomposition.py. I don't know if it's ok. |
I think this rtol change is ok for this one test. confirming with @interesaaat ? |
In the meantime, i actually updated the runner checks this time!! 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for all your help!!