Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use tokens directly in css for badge partial #31847

Merged
merged 1 commit into from
Jun 27, 2024
+11 −6
Merged

chore: use tokens directly in css for badge partial #31847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-web-components-d72dcdbe-ace1-4bd1-b429-2565a3ab8c39.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "chore: use tokens directly in css for badge partial",
"packageName": "@fluentui/web-components",
"email": "mmansour@microsoft.com",
"dependentChangeType": "patch"
}
10 changes: 4 additions & 6 deletions packages/web-components/src/styles/partials/badge.partials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ import {
warningState,
} from '../states/index.js';

const textPadding = spacingHorizontalXXS;

export const badgeBaseStyles = css.partial`
${display('inline-flex')} :host {
position: relative;
Expand All @@ -82,7 +80,7 @@ export const badgeBaseStyles = css.partial`
line-height: ${lineHeightBase200};
min-width: 20px;
height: 20px;
padding-inline: calc(${spacingHorizontalXS} + ${textPadding});
padding-inline: calc(${spacingHorizontalXS} + ${spacingHorizontalXXS});
border-radius: ${borderRadiusCircular};
border-color: ${colorTransparentStroke};
background-color: ${colorBrandBackground};
Expand Down Expand Up @@ -140,7 +138,7 @@ export const badgeSizeStyles = css.partial`
height: 16px;
font-size: ${fontSizeBase100};
line-height: ${lineHeightBase100};
padding-inline: calc(${spacingHorizontalXXS} + ${textPadding});
padding-inline: calc(${spacingHorizontalXXS} + ${spacingHorizontalXXS});
}
:host(${smallState}) ::slotted(svg) {
font-size: 12px;
Expand All @@ -150,7 +148,7 @@ export const badgeSizeStyles = css.partial`
height: 24px;
font-size: ${fontSizeBase200};
line-height: ${lineHeightBase200};
padding-inline: calc(${spacingHorizontalXS} + ${textPadding});
padding-inline: calc(${spacingHorizontalXS} + ${spacingHorizontalXXS});
}
:host(${largeState}) ::slotted(svg) {
font-size: 16px;
Expand All @@ -160,7 +158,7 @@ export const badgeSizeStyles = css.partial`
height: 32px;
font-size: ${fontSizeBase200};
line-height: ${lineHeightBase200};
padding-inline: calc(${spacingHorizontalSNudge} + ${textPadding});
padding-inline: calc(${spacingHorizontalSNudge} + ${spacingHorizontalXXS});
}
:host(${extraLargeState}) ::slotted(svg) {
font-size: 20px;
Expand Down
Loading