Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use tokens directly in css for badge partial #31847

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

mohamedmansour
Copy link
Contributor

Previous Behavior

Caching local variable for spacingHorizontalXXS

New Behavior

Uses the local variable directly in the css.

Related Issue(s)

This is to help do CSS Hoisting, tokens should be used in CSS not outside.

@mohamedmansour mohamedmansour marked this pull request as ready for review June 27, 2024 18:14
@mohamedmansour mohamedmansour requested a review from a team as a code owner June 27, 2024 18:14
@mohamedmansour mohamedmansour changed the title chore: use tokens directly in css chore: use tokens directly in css for badge partial Jun 27, 2024
@chrisdholt chrisdholt enabled auto-merge (squash) June 27, 2024 18:39
@chrisdholt chrisdholt merged commit c05bfd2 into microsoft:master Jun 27, 2024
10 checks passed
@mohamedmansour mohamedmansour deleted the mmansour-badge branch June 28, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants