fix(react-dialog): make aria-* properties reassignable #25092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9c0eed5:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ff55fc0e1abd7e61331bbcba18e066b6c449ba79 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1266 | 1268 | 5000 | |
| Button | mount | 919 | 911 | 5000 | |
| FluentProvider | mount | 1476 | 1482 | 5000 | |
| FluentProviderWithTheme | mount | 580 | 580 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 536 | 543 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 576 | 573 | 10 | |
| MakeStyles | mount | 1956 | 1962 | 50000 | |
| SpinButton | mount | 2329 | 2350 | 5000 |
bsunderhus
changed the title
ling1726
approved these changes
Oct 5, 2022
bsunderhus
force-pushed
the
react-dialog/fix--aria-properties-should-be-reassignable
branch
from
8ca6f89 to
9c0eed5
Compare
auto-merge was automatically disabled
October 5, 2022 16:59
Pull request was closed
khmakoto
approved these changes
Oct 5, 2022
| @@ -1,7 +1,7 @@ | |||
| import * as React from 'react'; | |||
| import { useModalAttributes } from '@fluentui/react-tabster'; | |||
| import { applyTriggerPropsToChildren, getTriggerChild, useEventCallback } from '@fluentui/react-utilities'; | |||
| import { DialogTriggerProps, DialogTriggerState } from './DialogTrigger.types'; | |||
| import type { DialogTriggerProps, DialogTriggerState } from './DialogTrigger.types'; | |||
| import { useDialogContext_unstable, useDialogSurfaceContext_unstable } from '../../contexts'; | |||
| import { useARIAButtonProps } from '@fluentui/react-aria'; | |||
There was a problem hiding this comment.
Suggested change
| import { useARIAButtonProps } from '@fluentui/react-aria'; | |
| import type { useARIAButtonProps } from '@fluentui/react-aria'; |
bsunderhus
deleted the
react-dialog/fix--aria-properties-should-be-reassignable
branch
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 10, 2022
* master: (23 commits) Revert "chore: screener-run workflow should report to PR (microsoft#25144)" (microsoft#25145) chore: screener-run workflow should report to PR (microsoft#25144) applying package updates fix: The Tooltip should not hide if it gets keyboard focus (microsoft#25138) fix: Tooltip should not hide if an element inside it gets focused (microsoft#25140) Create react-migration-v8-v9 with shims and stories (microsoft#25121) fix: CheckboxField to set a generated ID on the input, to match the label's htmlFor (microsoft#25079) feat: Overflow menu should be registered in overflowManager (microsoft#25091) fix: version-bump generator removes beachball disallowedChangeType config (microsoft#25130) fix: new overflow items should only be enqueued while observing (microsoft#25122) fix(script): allow runPublished call from CLI (microsoft#25127) feat: add vertical variation for toolbar (microsoft#24940) ProgressField implementation and stories (microsoft#25103) fix: Dropdown icon layout with no placeholder/value (microsoft#25049) chore: add a bundle size fixture (Button, Provider & theme) (microsoft#25113) feat: Adding subtle transition between states on Button components (microsoft#25106) Revert "chore: screener-run workflow should report to PR (microsoft#25096)" (microsoft#25115) chore: screener-run workflow should report to PR (microsoft#25096) fix(react-dialog): aria-* properties should be reassignable (microsoft#25092) fix(scripts): don't run publish if web-components are affected (microsoft#25095) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
aria-describedbyoraria-labelledbyproperties provided by the user forDialogSurfacewill be overridden to internal values.New Behavior
aria-*properties will be properly reassigned by the user, this ensure removingaria-describedbyby assigning it toundefinedon scenarios where we don't want screen readers to read the body of the dialog.aria-describebyis recommended