fix: CheckboxField to set a generated ID on the input, to match the label's htmlFor #25079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 724d581:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a8e81b5296f1551e74010c1d2ad9d37c6fd48306 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1620 | 1596 | 5000 | |
| Button | mount | 1137 | 1166 | 5000 | |
| FluentProvider | mount | 2000 | 1950 | 5000 | |
| FluentProviderWithTheme | mount | 765 | 775 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 703 | 710 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 779 | 739 | 10 | |
| MakeStyles | mount | 2315 | 2310 | 50000 | |
| SpinButton | mount | 3001 | 3119 | 5000 |
spmonahan
approved these changes
Oct 6, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 10, 2022
* master: (23 commits) Revert "chore: screener-run workflow should report to PR (microsoft#25144)" (microsoft#25145) chore: screener-run workflow should report to PR (microsoft#25144) applying package updates fix: The Tooltip should not hide if it gets keyboard focus (microsoft#25138) fix: Tooltip should not hide if an element inside it gets focused (microsoft#25140) Create react-migration-v8-v9 with shims and stories (microsoft#25121) fix: CheckboxField to set a generated ID on the input, to match the label's htmlFor (microsoft#25079) feat: Overflow menu should be registered in overflowManager (microsoft#25091) fix: version-bump generator removes beachball disallowedChangeType config (microsoft#25130) fix: new overflow items should only be enqueued while observing (microsoft#25122) fix(script): allow runPublished call from CLI (microsoft#25127) feat: add vertical variation for toolbar (microsoft#24940) ProgressField implementation and stories (microsoft#25103) fix: Dropdown icon layout with no placeholder/value (microsoft#25049) chore: add a bundle size fixture (Button, Provider & theme) (microsoft#25113) feat: Adding subtle transition between states on Button components (microsoft#25106) Revert "chore: screener-run workflow should report to PR (microsoft#25096)" (microsoft#25115) chore: screener-run workflow should report to PR (microsoft#25096) fix(react-dialog): aria-* properties should be reassignable (microsoft#25092) fix(scripts): don't run publish if web-components are affected (microsoft#25095) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…abel's htmlFor (microsoft#25079) * Have field _always_ set a generated ID on the input component, even if there is no field label. * Refactor useField to not set input props to `undefined` if they aren't relevant (instead they will be unset in that case) * Add tests for these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Field sets the input's
idtoundefinedif there is no field label. CheckboxField is unique in that it doesn't use the field label, but rather an internal label built into Checkbox. The Field'sid={undefined}gets passed to the Checkbox component, which prevents it from setting a generated ID on the input element.New Behavior
undefinedif they aren't relevant (instead they will be unset in that case)Related Issue(s)