-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log pipeline - populate logs into kusto #170
Draft
kaibocai
wants to merge
4
commits into
main
Choose a base branch
from
kaibocai/fix-log
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
client/src/main/java/com/microsoft/durabletask/log/FunctionKustoHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package com.microsoft.durabletask.log; | ||
|
||
import java.io.PrintStream; | ||
import java.util.Arrays; | ||
import java.util.logging.Handler; | ||
import java.util.logging.Level; | ||
import java.util.logging.LogRecord; | ||
|
||
class FunctionKustoHandler extends Handler { | ||
private static final String FUNCTIONSKUSTOPREFIX = "LanguageWorkerConsoleLog"; | ||
private static final String DURABLEPREFIX = "DURABLE_JAVA_SDK"; | ||
@Override | ||
public void publish(LogRecord record) { | ||
if (record != null && record.getLevel() != null) { | ||
PrintStream output = record.getLevel().intValue() <= Level.INFO.intValue() ? System.out : System.err; | ||
output.printf("%s%s [%s] {%s.%s}: %s%n", | ||
FUNCTIONSKUSTOPREFIX, | ||
DURABLEPREFIX, | ||
record.getLevel(), | ||
record.getSourceClassName(), | ||
record.getSourceMethodName(), | ||
record.getMessage()); | ||
if (record.getThrown() != null) { | ||
output.printf("%s%s%s%n", FUNCTIONSKUSTOPREFIX, DURABLEPREFIX, Arrays.toString(record.getThrown().getStackTrace())); | ||
} | ||
} | ||
} | ||
|
||
@Override | ||
public void flush() { | ||
System.out.flush(); | ||
System.err.flush(); | ||
} | ||
|
||
@Override | ||
public void close() throws SecurityException { } | ||
} |
34 changes: 34 additions & 0 deletions
34
client/src/main/java/com/microsoft/durabletask/log/LoggerManager.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package com.microsoft.durabletask.log; | ||
|
||
import java.util.logging.*; | ||
|
||
public class LoggerManager { | ||
private static final Logger logger = initLogger(); | ||
|
||
private static Logger initLogger() { | ||
Logger logger = Logger.getAnonymousLogger(); | ||
logger.setUseParentHandlers(false); | ||
logger.setLevel(Level.ALL); | ||
logger.addHandler(new FunctionKustoHandler()); | ||
return logger; | ||
} | ||
|
||
public static void setHandler(Handler handler) { | ||
clearHandler(); | ||
addHandler(handler); | ||
} | ||
|
||
public static void addHandler(Handler handler) { | ||
logger.addHandler(handler); | ||
} | ||
|
||
private static void clearHandler() { | ||
for (Handler handler : logger.getHandlers()) { | ||
logger.removeHandler(handler); | ||
} | ||
} | ||
|
||
public static Logger getLogger() { | ||
return logger; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core logging abstractions can be in
durabletask-client
but anything specific to the either Kusto or Functions should instead go into thedurabletask-azure-functions
package. This is very important becausedurabletask-client
will also be used outside of Azure by Dapr OSS customers, and we don't want to add any Azure-specific logic or dependencies for those users.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.