Fix log pipeline - populate logs into kusto #170
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaibocai
requested review from
cgillum and
shreyas-gopalakrishna
as code owners
cgillum
requested changes
Oct 13, 2023
| import java.util.logging.LogRecord; | ||
|
|
||
| class FunctionKustoHandler extends Handler { | ||
| private static final String FUNCTIONSKUSTOPREFIX = "LanguageWorkerConsoleLog"; |
There was a problem hiding this comment.
Core logging abstractions can be in durabletask-client but anything specific to the either Kusto or Functions should instead go into the durabletask-azure-functions package. This is very important because durabletask-client will also be used outside of Azure by Dapr OSS customers, and we don't want to add any Azure-specific logic or dependencies for those users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
With the current logging logic in the SDK, the logs are not recorded anywhere, causing the logs in the SDK to be meaningless.
This PR updates the current Java Util Logger with
FunctionKustoHandler, a customizedjava.util.logging.Handlerthat will stream the logs into kusto table. The picture below shows an example.Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information