Various fixes #410
Various fixes #410
Conversation
nxtn
force-pushed
the
linux
branch
4 times, most recently
from
c2bbb1c
to
99ee35a
Compare
|
Looks great so far. Thanks for tackling this. |
|
Only |
|
Enabling PR status checks should be as simple as installing Azure Pipelines and granting it access to the repo. We'll soon be ready for full CI testing. |
| dt.BinaryLocator = new SymbolServerLocator(""); | ||
| return dt; | ||
| if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) | ||
| { |
There was a problem hiding this comment.
Maybe I should remove "LoadCoreDump/LoadCrashDump" and just publish "LoadDump" and have the right reader selected based on either the operating system or the header of the file itself. (The latter gets complicated because DbgEngDataReader allows for .zip and .cab files too, which is useful for internal Microsoft developers.)
There was a problem hiding this comment.
In fact, some functionalities are still available for LoadCoreDump on Windows, which don't request information from DAC.
There was a problem hiding this comment.
Good point. I'll leave this as-is for now.
| { | ||
| value = Unsafe.As<byte, T>(ref buffer[0]); | ||
| value = Unsafe.As<byte, T>(ref MemoryMarshal.GetReference(buffer)); |
There was a problem hiding this comment.
Ah right. Thanks for these cleanups. I'm still getting used to Unsafe.As and MemoryMarshal after being stuck on an older version of Desktop .Net for years.
No description provided.