Remove size checks to reduce 10 test failures

microsoft · Dec 11, 2019 · c2bbb1c · c2bbb1c
1 parent aba7822
commit c2bbb1c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/Microsoft.Diagnostics.Runtime/src/DataReaders/Core/CoreDumpReader.cs b/src/Microsoft.Diagnostics.Runtime/src/DataReaders/Core/CoreDumpReader.cs
@@ -159,7 +159,7 @@ public ulong ReadPointerUnsafe(ulong addr)
         public unsafe bool Read<T>(ulong addr, out T value) where T : unmanaged
         {
             Span<byte> buffer = stackalloc byte[sizeof(T)];
-            if (ReadMemory(addr, buffer, out int read) && read == sizeof(T))
+            if (ReadMemory(addr, buffer, out int _))
             {
                 value = Unsafe.As<byte, T>(ref buffer[0]);
                 return true;
@@ -178,7 +178,7 @@ public T ReadUnsafe<T>(ulong addr) where T : unmanaged
         public bool ReadPointer(ulong address, out ulong value)
         {
             Span<byte> buffer = stackalloc byte[IntPtr.Size];
-            if (ReadMemory(address, buffer, out int read) && read == IntPtr.Size)
+            if (ReadMemory(address, buffer, out int _))
             {
                 value = buffer.AsPointer();
                 return true;

diff --git a/src/Microsoft.Diagnostics.Runtime/src/DataReaders/DbgEng/DbgEngDataReader.cs b/src/Microsoft.Diagnostics.Runtime/src/DataReaders/DbgEng/DbgEngDataReader.cs
@@ -275,7 +275,7 @@ public ulong ReadPointerUnsafe(ulong addr)
         public unsafe bool Read<T>(ulong addr, out T value) where T : unmanaged
         {
             Span<byte> buffer = stackalloc byte[sizeof(T)];
-            if (ReadMemory(addr, buffer, out int read) && read == sizeof(T))
+            if (ReadMemory(addr, buffer, out int _))
             {
                 value = Unsafe.As<byte, T>(ref buffer[0]);
                 return true;
@@ -294,7 +294,7 @@ public T ReadUnsafe<T>(ulong addr) where T : unmanaged
         public bool ReadPointer(ulong address, out ulong value)
         {
             Span<byte> buffer = stackalloc byte[IntPtr.Size];
-            if (ReadMemory(address, buffer, out int read) && read == IntPtr.Size)
+            if (ReadMemory(address, buffer, out int _))
             {
                 value = buffer.AsPointer();
                 return true;

diff --git a/src/Microsoft.Diagnostics.Runtime/src/DataReaders/Live/LiveDataReader.cs b/src/Microsoft.Diagnostics.Runtime/src/DataReaders/Live/LiveDataReader.cs
@@ -194,7 +194,7 @@ public ulong ReadPointerUnsafe(ulong addr)
         public unsafe bool Read<T>(ulong addr, out T value) where T : unmanaged
         {
             Span<byte> buffer = stackalloc byte[sizeof(T)];
-            if (ReadMemory(addr, buffer, out int read) && read == sizeof(T))
+            if (ReadMemory(addr, buffer, out int _))
             {
                 value = Unsafe.As<byte, T>(ref buffer[0]);
                 return true;
@@ -213,7 +213,7 @@ public T ReadUnsafe<T>(ulong addr) where T : unmanaged
         public bool ReadPointer(ulong address, out ulong value)
         {
             Span<byte> buffer = stackalloc byte[IntPtr.Size];
-            if (ReadMemory(address, buffer, out int read) && read == IntPtr.Size)
+            if (ReadMemory(address, buffer, out int _))
             {
                 value = buffer.AsPointer();
                 return true;

diff --git a/src/Microsoft.Diagnostics.Runtime/src/Linux/LinuxLiveDataReader.cs b/src/Microsoft.Diagnostics.Runtime/src/Linux/LinuxLiveDataReader.cs
@@ -181,7 +181,7 @@ public ulong ReadPointerUnsafe(ulong address)
         public unsafe bool Read<T>(ulong addr, out T value) where T : unmanaged
         {
             Span<byte> buffer = stackalloc byte[sizeof(T)];
-            if (ReadMemory(addr, buffer, out int read) && read == sizeof(T))
+            if (ReadMemory(addr, buffer, out int _))
             {
                 value = Unsafe.As<byte, T>(ref buffer[0]);
                 return true;
@@ -200,7 +200,7 @@ public T ReadUnsafe<T>(ulong addr) where T : unmanaged
         public bool ReadPointer(ulong address, out ulong value)
         {
             Span<byte> buffer = stackalloc byte[IntPtr.Size];
-            if (ReadMemory(address, buffer, out int read) && read == IntPtr.Size)
+            if (ReadMemory(address, buffer, out int _))
             {
                 value = buffer.AsPointer();
                 return true;