Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4163] log multi-choice options in App Insights #4164

Merged
merged 12 commits into from
Mar 24, 2022

Conversation

breakingram
Copy link
Contributor

@breakingram breakingram commented Mar 17, 2022

Fixes #4163

Description

This pull request fixes a bug for the multi-choice options not getting logged in application insights.

@breakingram breakingram changed the title bug fix: log multi-choice options in App Insights port: [#4163] log multi-choice options in App Insights Mar 17, 2022
@coveralls
Copy link

coveralls commented Mar 21, 2022

Pull Request Test Coverage Report for Build 2031519141

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 156 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.09%) to 84.482%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/botFrameworkHttpClient.ts 1 94.74%
libraries/botbuilder/src/inspectionMiddleware.ts 1 95.77%
libraries/botbuilder/src/skills/skillHandler.ts 1 89.29%
libraries/botframework-connector/src/auth/channelValidation.ts 1 93.18%
libraries/botframework-connector/src/auth/credentialProvider.ts 1 88.89%
libraries/botbuilder-lg/src/analyzer.ts 2 95.42%
libraries/botframework-connector/src/auth/governmentChannelValidation.ts 2 89.13%
libraries/botframework-connector/src/auth/enterpriseChannelValidation.ts 3 82.61%
libraries/botbuilder-dialogs/src/dialogManager.ts 4 90.63%
libraries/botbuilder-lg/src/evaluator.ts 5 92.7%
Totals Coverage Status
Change from base Build 1995608014: -0.09%
Covered Lines: 19751
Relevant Lines: 22143

💛 - Coveralls

@EricDahlvang EricDahlvang added the Automation: No parity PR does not need to be applied to other languages. label Mar 22, 2022
@breakingram breakingram marked this pull request as ready for review March 23, 2022 20:43
@breakingram breakingram requested a review from a team as a code owner March 23, 2022 20:43
@EricDahlvang EricDahlvang merged commit a700088 into main Mar 24, 2022
@EricDahlvang EricDahlvang deleted the ramfattah/telemetry-choices-properties branch March 24, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Bug fix: multi-choice options can now be logged in App Insights (#6261)
4 participants