Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Bug fix: multi-choice options can now be logged in App Insights (#6261) #4163

Closed
github-actions bot opened this issue Mar 17, 2022 · 1 comment · Fixed by #4164
Closed

port: Bug fix: multi-choice options can now be logged in App Insights (#6261) #4163

github-actions bot opened this issue Mar 17, 2022 · 1 comment · Fixed by #4164
Assignees
@breakingram
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. parity The issue describes a gap in parity between two or more platforms.
Milestone
R16

Comments

@github-actions
Copy link

The changes in Bug fix: multi-choice options can now be logged in App Insights (#6261) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6262

Description

Fixed multi-choice prompt options bug not being logged by Application Insights.

Specific Changes

Testing

Before

After (choices are logged)

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Mar 17, 2022
@gabog gabog added this to the R16 milestone Mar 17, 2022
@breakingram breakingram mentioned this issue Mar 17, 2022
Merged
@breakingram
Copy link
Contributor

in progress.

@breakingram breakingram removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Mar 23, 2022
EricDahlvang pushed a commit that referenced this issue Mar 24, 2022
@breakingram
port: [#4163] log multi-choice options in App Insights (#4164)
a700088 
* bug fix: log multi-choice options in App Insights

* unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@breakingram breakingram

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
R16
Development

Successfully merging a pull request may close this issue.

port: [#4163] log multi-choice options in App Insights microsoft/botbuilder-js
2 participants
@gabog @breakingram