Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Add ThrowOnRecursive to LG AnalyzerOptions (#5872) #3917

Closed
github-actions bot opened this issue Sep 2, 2021 · 1 comment · Fixed by #4156
Closed

port: Add ThrowOnRecursive to LG AnalyzerOptions (#5872) #3917

github-actions bot opened this issue Sep 2, 2021 · 1 comment · Fixed by #4156
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms. Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Milestone
R16

Comments

@github-actions
Copy link

github-actions bot commented Sep 2, 2021 •
edited by EricDahlvang
Loading

The changes in Add ThrowOnRecursive to LG AnalyzerOptions (#5872) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes https://github.com/microsoft/botbuilder-dotnet/issues/5814

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Sep 2, 2021
@EricDahlvang EricDahlvang changed the title port: Add ThrowOnRecursive to LG EvaluationOptions (#5872) port: Add ThrowOnRecursive to LG AnalyzerOptions (#5872) Sep 2, 2021
@mrivera-ms mrivera-ms added P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Mar 3, 2022
@mrivera-ms mrivera-ms added this to the R16 milestone Mar 3, 2022
@ceciliaavila
Copy link
Collaborator

@mrivera-ms in progress

@ceciliaavila ceciliaavila mentioned this issue Mar 11, 2022
Merged
mrivera-ms pushed a commit that referenced this issue Mar 17, 2022
@ceciliaavila
port: [#3917] Add ThrowOnRecursive to LG AnalyzerOptions (#5872) (#4156)
0388aa2 
* Add ThrowOnRecursive to LG AnalyzerOptions

* Update botbuilder-lg.api documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms. Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Projects
None yet
Milestone
R16
Development

Successfully merging a pull request may close this issue.

port: [#3917] Add ThrowOnRecursive to LG AnalyzerOptions (#5872) microsoft/botbuilder-js
3 participants
@JuanAr @ceciliaavila @mrivera-ms