Template Analyzer does not detect loops, Template Evaluator is now responsible for loop detection

[sbacha]

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

What package version of the SDK are you using.
4.14.1

Describe the bug

We have design time validation where we use template analyzer to detect problems within the lg resource, it seems this code has moved from the analyzer to the evaluator which requires scope.

To Reproduce

Steps to reproduce the behavior:
Create an Lg File

# timeOfDayGreeting
- my name is ${day()}
# day
- ${timeOfDayGreeting()}

Parse Lg file
Loop over the templates:
var analyzeTemplateResult = templates.AnalyzeTemplate(template.Name);

Expected behavior

AnalyzeTemplate should throw an exception with loop detected message

Additional context

81f0a87?branch=81f0a87998fac2780e23493bf42ba0d90d3feb5a&diff=split