Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Added dialogs property of AdaptiveDialog to the hidden list (#5785) #3883

Closed
github-actions bot opened this issue Jul 23, 2021 · 0 comments · Fixed by #3886
Closed

port: Added dialogs property of AdaptiveDialog to the hidden list (#5785) #3883

github-actions bot opened this issue Jul 23, 2021 · 0 comments · Fixed by #3886
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in Added dialogs property of AdaptiveDialog to the hidden list (#5785) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5566 ## Description Hide the dialogs property of AdaptiveDialog in the Composer UI by adding it to the hidden list in the AdaptiveDialog.uischema file.

Note that as of today this change will not be used by Composer, it is using a local copy of a uischema file that drives it's behavior, so another Issue and PR were created for this in the Composer repo:

AdaptiveDialog has dialogs property added in declarative schema and that property should be hidden.

fix: Added dialogs to hidden list for AdaptiveDialog in index.ts file

The change was also added here so that once Composer stops using the local file this change will already be reflected in the SDK AdaptiveDialog.uischema file.

Specific Changes

Added "dialogs" property to the AdaptiveDialog.uischema file.

Testing

This can't be tested yet today as Composer is not using the properties in the SDK uischema file yet, but the change was done in a consistent manner as the other hidden properties in the AdaptiveDialog.uischema were also done.

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jul 23, 2021
joshgummersall pushed a commit that referenced this issue Jul 26, 2021
port: hide dialogs property
9650adc 
Fixes #3883
@joshgummersall joshgummersall mentioned this issue Jul 26, 2021
Merged
joshgummersall pushed a commit that referenced this issue Jul 29, 2021
port: hide dialogs property
bdeab7b 
Fixes #3883
joshgummersall pushed a commit that referenced this issue Jul 29, 2021
port: hide dialogs property (#3886)
c797b67 
* port: hide dialogs property

Fixes #3883

* fix: bump chromedriver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: hide dialogs property microsoft/botbuilder-js
0 participants