Added dialogs property of AdaptiveDialog to the hidden list #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeParrishMSFT
requested review from
tomlm,
luhan2017 and
a-b-r-o-w-n
and removed request for
tomlm
Pull Request Test Coverage Report for Build 258839
💛 - Coveralls |
mrivera-ms
approved these changes
Jul 23, 2021
This was referenced Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5566
Description
Hide the dialogs property of AdaptiveDialog in the Composer UI by adding it to the hidden list in the AdaptiveDialog.uischema file.
Note that as of today this change will not be used by Composer, it is using a local copy of a uischema file that drives it's behavior, so another Issue and PR were created for this in the Composer repo:
AdaptiveDialog has dialogs property added in declarative schema and that property should be hidden.
fix: Added dialogs to hidden list for AdaptiveDialog in index.ts file
The change was also added here so that once Composer stops using the local file this change will already be reflected in the SDK AdaptiveDialog.uischema file.
Specific Changes
Added "dialogs" property to the AdaptiveDialog.uischema file.
Testing
This can't be tested yet today as Composer is not using the properties in the SDK uischema file yet, but the change was done in a consistent manner as the other hidden properties in the AdaptiveDialog.uischema were also done.