-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSO with skill dialog and expected replies #3818
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagatmishra2007
requested review from
cleemullins,
gabog,
johnataylor,
mrivera-ms and
tomlm
as code owners
April 28, 2020 02:05
gabog
suggested changes
Apr 28, 2020
gabog
reviewed
Apr 28, 2020
gabog
reviewed
Apr 28, 2020
gabog
reviewed
Apr 28, 2020
gabog
reviewed
Apr 28, 2020
carlosscastro
previously requested changes
Apr 28, 2020
stevengum
previously requested changes
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some refactoring to do here, perhaps we should schedule something offline to talk it out with the required parties
gabog
approved these changes
Apr 28, 2020
tests/Microsoft.Bot.Builder.Dialogs.Tests/SsoSkillDialogTests.cs
Outdated
Show resolved
Hide resolved
gabog
dismissed stale reviews from stevengum and carlosscastro
April 28, 2020 22:19
Feedback addressed
stevengum
reviewed
Apr 28, 2020
stevengum
approved these changes
Apr 28, 2020
gabog
approved these changes
Apr 28, 2020
cleemullins
approved these changes
Apr 28, 2020
This was referenced Apr 28, 2020
This was referenced Apr 29, 2020
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support SSO with skill dialog and expected replies